Use correctly mirrored points for ideal bounds of launcher item icons.

ash/wm/panels/panel_window_resizer_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/panels/panel_window_resizer.h"
 
 #include "ash/launcher/launcher.h"
 #include "ash/launcher/launcher_model.h"
 #include "ash/root_window_controller.h"
 #include "ash/shelf/shelf_layout_manager.h"
@@ skipping 175 matching lines @@
   }
 
  private:
   scoped_ptr<PanelWindowResizer> resizer_;
   internal::PanelLayoutManager* panel_layout_manager_;
   LauncherModel* model_;
 
   DISALLOW_COPY_AND_ASSIGN(PanelWindowResizerTest);
 };
 
+class PanelWindowResizerRTLTest : public PanelWindowResizerTest {
+ public:
+  PanelWindowResizerRTLTest() {}
+  virtual ~PanelWindowResizerRTLTest() {}
+
+  virtual void SetUp() OVERRIDE {
+    base::i18n::SetICUDefaultLocale("ar");
+    PanelWindowResizerTest::SetUp();
+    ASSERT_TRUE(base::i18n::IsRTL());
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(PanelWindowResizerRTLTest);
+};
+

[varkha, 2013/05/03 17:48:14]

RTL could be a test parameter set up with INSTANTIATE_TEST_CASE_P. Then all the
tests would run twice - with and without RTL. You can then tune which tests we
want to run with RTL and which not. I think this will improve the coverage.

 // Verifies a window can be dragged from the panel and detached and then
 // reattached.
 TEST_F(PanelWindowResizerTest, PanelDetachReattachBottom) {
   scoped_ptr<aura::Window> window(
       CreatePanelWindow(gfx::Rect(0, 0, 201, 201)));
   DetachReattachTest(window.get(), 0, -1);
 }
 
 TEST_F(PanelWindowResizerTest, PanelDetachReattachLeft) {
   ash::Shell* shell = ash::Shell::GetInstance();
@@ skipping 201 matching lines @@
 
   // When dropped it should return to the default container.
   EXPECT_EQ(internal::kShellWindowId_WorkspaceContainer,
             window->parent()->id());
 }
 
 TEST_F(PanelWindowResizerTest, DragReordersPanelsHorizontal) {
   DragAlongShelfReorder(-1, 0);
 }
 
+TEST_F(PanelWindowResizerRTLTest, DragReordersPanelsHorizontal) {
+  DragAlongShelfReorder(1, 0);
+}
+
 TEST_F(PanelWindowResizerTest, DragReordersPanelsVertical) {
   ash::Shell* shell = ash::Shell::GetInstance();
   shell->SetShelfAlignment(SHELF_ALIGNMENT_LEFT, shell->GetPrimaryRootWindow());
   DragAlongShelfReorder(0, -1);
 }
 
 }  // namespace internal
 }  // namespace ash