Use correctly mirrored points for ideal bounds of launcher item icons.

ash/wm/panels/panel_layout_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/panels/panel_layout_manager.h"
 
 #include "ash/ash_switches.h"
 #include "ash/launcher/launcher.h"
 #include "ash/launcher/launcher_button.h"
 #include "ash/launcher/launcher_model.h"
 #include "ash/launcher/launcher_view.h"
 #include "ash/root_window_controller.h"
 #include "ash/screen_ash.h"
 #include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shelf/shelf_types.h"
 #include "ash/shelf/shelf_widget.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/test/ash_test_base.h"
 #include "ash/test/launcher_view_test_api.h"
 #include "ash/test/shell_test_api.h"
 #include "ash/test/test_launcher_delegate.h"
 #include "ash/wm/window_util.h"
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
+#include "base/i18n/rtl.h"
 #include "base/run_loop.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/root_window.h"
 #include "ui/aura/test/event_generator.h"
 #include "ui/aura/test/test_windows.h"
 #include "ui/aura/window.h"
 #include "ui/views/corewm/corewm_switches.h"
 #include "ui/views/widget/widget.h"
 
 namespace ash {
@@ skipping 224 matching lines @@
   scoped_ptr<test::LauncherViewTestAPI> launcher_view_test_;
 
   bool IsHorizontal(ShelfAlignment alignment) {
     return alignment == SHELF_ALIGNMENT_BOTTOM ||
            alignment == SHELF_ALIGNMENT_TOP;
   }
 
   DISALLOW_COPY_AND_ASSIGN(PanelLayoutManagerTest);
 };
 
+class PanelLayoutManagerRTLTest : public PanelLayoutManagerTest {
+ public:
+  PanelLayoutManagerRTLTest() {}
+  virtual ~PanelLayoutManagerRTLTest() {}
+
+  virtual void SetUp() OVERRIDE {
+    base::i18n::SetICUDefaultLocale("ar");
+    PanelLayoutManagerTest::SetUp();
+    ASSERT_TRUE(base::i18n::IsRTL());
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(PanelLayoutManagerRTLTest);
+};
+

[varkha, 2013/05/03 17:48:14]

RTL could be a test parameter set up with INSTANTIATE_TEST_CASE_P. Then all the
tests would run twice - with and without RTL.

[flackr, 2013/05/17 20:31:14]

This would be nice, however as far as I can tell it would require reimplementing
AshTestBase. AshTestBase extends testing::Test, but in order to use
INSTANTIATE_TEST_CASE_P you have to extend testing::TestWithParam<T> where T is
the type of the test parameter.

 // Tests that a created panel window is successfully added to the panel
 // layout manager.
 TEST_F(PanelLayoutManagerTest, AddOnePanel) {
   gfx::Rect bounds(0, 0, 201, 201);
   scoped_ptr<aura::Window> window(CreatePanelWindow(bounds));
   EXPECT_EQ(GetPanelContainer(window.get()), window->parent());
   EXPECT_NO_FATAL_FAILURE(IsPanelAboveLauncherIcon(window.get()));
 }
 
+// Tests that a created panel window is above the launcher icon in RTL.
+TEST_F(PanelLayoutManagerRTLTest, AddOnePanel) {
+  gfx::Rect bounds(0, 0, 201, 201);
+  scoped_ptr<aura::Window> window(CreatePanelWindow(bounds));
+  EXPECT_EQ(GetPanelContainer(window.get()), window->parent());
+  EXPECT_NO_FATAL_FAILURE(IsPanelAboveLauncherIcon(window.get()));
+  EXPECT_NO_FATAL_FAILURE(IsCalloutAboveLauncherIcon(window.get()));
+}
+
 // Tests that a created panel window is successfully aligned over a hidden
 // launcher icon.
 TEST_F(PanelLayoutManagerTest, PanelAlignsToHiddenLauncherIcon) {
   gfx::Rect bounds(0, 0, 201, 201);
   SetShelfAutoHideBehavior(Shell::GetPrimaryRootWindow(),
                            SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS);
   RunAllPendingInMessageLoop();
   scoped_ptr<aura::Window> window(CreatePanelWindow(bounds));
   EXPECT_EQ(GetPanelContainer(window.get()), window->parent());
   EXPECT_NO_FATAL_FAILURE(IsPanelAboveLauncherIcon(window.get()));
@@ skipping 387 matching lines @@
   RunAllPendingInMessageLoop();
 
   // Windows should be restored to their prior state.
   EXPECT_TRUE(w1->IsVisible());
   EXPECT_FALSE(w2->IsVisible());
   EXPECT_TRUE(w3->IsVisible());
 }
 
 }  // namespace internal
 }  // namespace ash