Replace some trivial WebKitSystemInterface wrappers with direct calls to SPI.

Source/core/rendering/RenderThemeChromiumMac.mm

 /*
  * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Google, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 126 matching lines @@
 - (BOOL)isFlipped {
     return [[NSGraphicsContext currentContext] isFlipped];
 }
 
 - (NSText *)currentEditor {
     return nil;
 }
 
 @end
 
+// Forward declare Mac SPIs.
+extern "C" {
+void _NSDrawCarbonThemeBezel(NSRect frame, BOOL enabled, BOOL flipped);
+void _NSDrawCarbonThemeListBox(NSRect frame, BOOL enabled, BOOL flipped, BOOL always_yes);
+}
+
 namespace WebCore {
 
 using namespace HTMLNames;
 
 enum {
     topMargin,
     rightMargin,
     bottomMargin,
     leftMargin
 };
@@ skipping 572 matching lines @@
     LocalCurrentGraphicsContext localContext(paintInfo.context);
 
 #if __MAC_OS_X_VERSION_MIN_REQUIRED <= 1070
     bool useNSTextFieldCell = o->style()->hasAppearance()
         && o->style()->visitedDependentColor(CSSPropertyBackgroundColor) == Color::white
         && !o->style()->hasBackgroundImage();
 
     // We do not use NSTextFieldCell to draw styled text fields on Lion and SnowLeopard because
     // there are a number of bugs on those platforms that require NSTextFieldCell to be in charge
     // of painting its own background. We need WebCore to paint styled backgrounds, so we'll use
-    // this WebCoreSystemInterface function instead.
+    // this AppKit SPI function instead.
     if (!useNSTextFieldCell) {
-        WKDrawBezeledTextFieldCell(r, isEnabled(o) && !isReadOnlyControl(o));
+        _NSDrawCarbonThemeBezel(r, isEnabled(o) && !isReadOnlyControl(o), YES);

[Nico, 2013/05/01 01:02:18]

This is ok since this seems to be unnecessary on 10.8+

[Robert Sesek, 2013/05/01 23:58:43]

Correct.

         return false;
     }
 #endif
 
     NSTextFieldCell *textField = this->textField();
 
     GraphicsContextStateSaver stateSaver(*paintInfo.context);
 
     [textField setEnabled:(isEnabled(o) && !isReadOnlyControl(o))];
     [textField drawWithFrame:NSRect(r) inView:documentViewFor(o)];
@@ skipping 14 matching lines @@
 
     LocalCurrentGraphicsContext localContext(paintInfo.context);
     WKDrawCapsLockIndicator(localContext.cgContext(), r);
 
     return false;
 }
 
 bool RenderThemeChromiumMac::paintTextArea(RenderObject* o, const PaintInfo& paintInfo, const IntRect& r)
 {
     LocalCurrentGraphicsContext localContext(paintInfo.context);
-    WKDrawBezeledTextArea(r, isEnabled(o) && !isReadOnlyControl(o));
+    _NSDrawCarbonThemeListBox(r, isEnabled(o) && !isReadOnlyControl(o), YES, YES);

[Robert Sesek, 2013/05/01 23:58:43]

Filed.

     return false;
 }
 
 void RenderThemeChromiumMac::adjustTextAreaStyle(StyleResolver*, RenderStyle*, Element*) const
 {
 }
 
 const int* RenderThemeChromiumMac::popupButtonMargins() const
 {
     static const int margins[3][4] =
@@ skipping 1182 matching lines @@
 {
     return RenderMediaControlsChromium::paintMediaControlsPart(MediaEnterFullscreenButton, object, paintInfo, rect);
 }
 
 bool RenderThemeChromiumMac::paintMediaToggleClosedCaptionsButton(RenderObject* object, const PaintInfo& paintInfo, const IntRect& rect)
 {
     return RenderMediaControlsChromium::paintMediaControlsPart(MediaShowClosedCaptionsButton, object, paintInfo, rect);
 }
 
 } // namespace WebCore