[Autofill] Guard against the initialization failure of ICU Collator.

components/autofill/core/common/autofill_l10n_util.cc

Index: components/autofill/core/common/autofill_l10n_util.cc
diff --git a/components/autofill/core/common/autofill_l10n_util.cc b/components/autofill/core/common/autofill_l10n_util.cc
index 6f063a85f4f7821d0e962b3d26680b26d075d151..2ee517faf82b1feb224f83ae533092ae3b31f5af 100644
--- a/components/autofill/core/common/autofill_l10n_util.cc
+++ b/components/autofill/core/common/autofill_l10n_util.cc
@@ -6,15 +6,39 @@
 
 #include "base/i18n/string_compare.h"
 #include "base/logging.h"
+#include "base/metrics/histogram_macros.h"
 
 namespace autofill {
 namespace l10n {
 
-CaseInsensitiveCompare::CaseInsensitiveCompare() {
+CaseInsensitiveCompare::CaseInsensitiveCompare()
+    : CaseInsensitiveCompare(icu::Locale::getDefault()) {}
+
+CaseInsensitiveCompare::CaseInsensitiveCompare(const icu::Locale& locale) {
   UErrorCode error = U_ZERO_ERROR;
-  collator_.reset(icu::Collator::createInstance(error));
-  DCHECK(U_SUCCESS(error));
-  collator_->setStrength(icu::Collator::PRIMARY);
+  collator_.reset(icu::Collator::createInstance(locale, error));
+  if (!collator_) {
+    // On some systems, the default locale is invalid to the eyes of the ICU
+    // library. This could be due to a device-specific issue (has been seen in
+    // the wild on Android devices). In the failure case, |collator_| will be
+    // null. See http://crbug.com/558625.
+    icu_54::UnicodeString name;
+    std::string locale_name;
+    locale.getDisplayName(name).toUTF8String(locale_name);
+    LOG(ERROR) << "Failed to initialize the ICU Collator for "
+               << "CaseInsensitiveCompare with locale" << locale_name;
+    // Attempt to load the English locale.
+    collator_.reset(icu::Collator::createInstance(icu::Locale::getEnglish(),
+                    error));
+  }
+
+  if (collator_) {
+    collator_->setStrength(icu::Collator::PRIMARY);
+  } else {
+    LOG(ERROR) << "Failed to initialize the ICU Collator for "
+               << "CaseInsensitiveCompare with the English locale.";
+  }
+  UMA_HISTOGRAM_BOOLEAN("Autofill.IcuCollatorCreationSuccess", !!collator_);
 }
 
 CaseInsensitiveCompare::~CaseInsensitiveCompare() {
@@ -22,8 +46,11 @@ CaseInsensitiveCompare::~CaseInsensitiveCompare() {
 
 bool CaseInsensitiveCompare::StringsEqual(const base::string16& lhs,
                                           const base::string16& rhs) const {
-  return base::i18n::CompareString16WithCollator(*collator_, lhs, rhs) ==
-         UCOL_EQUAL;
+  if (collator_) {
+    return base::i18n::CompareString16WithCollator(*collator_, lhs, rhs) ==
+           UCOL_EQUAL;
+  }
+  return lhs == rhs;
 }
 
 }  // namespace l10n