tools/metrics/histograms/histograms.xml - Issue 1457393003: [Autofill] Guard against the initialization failure of ICU Collator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1457393003: [Autofill] Guard against the initialization failure of ICU Collator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 4132996a123981b68b3d1702cf59dd2010eaff41..ffe39af768274fe004a8f00995f6b731a259063e 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -2221,6 +2221,13 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<summary>The autofill state related to a submitted form.</summary>

</histogram>

+<histogram name="Autofill.IcuCollatorCreationSuccess" enum="BooleanSuccess">

Ilya Sherman 2015/11/19 22:31:54 Optional nit: A BooleanCreated with labels "Failed

Mathieu 2015/11/20 16:19:38 I find it would be slightly redundant because ther

+ <owner>mathp@chromium.org</owner>

+ <summary>

+ Tracks whether Autofill was able to create the ICU collator successfully.

+ </summary>

+</histogram>

<owner>isherman@chromium.org</owner>

« components/autofill/core/common/autofill_l10n_util.cc ('K') | « components/autofill/core/common/autofill_l10n_util.cc ('k') | no next file » | no next file with comments »