[Autofill] Guard against the initialization failure of ICU Collator.

components/autofill/core/browser/autofill_metrics_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_metrics.h"
 
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_service.h"
 #include "base/run_loop.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
 #include "base/time/time.h"
 #include "components/autofill/core/browser/autofill_external_delegate.h"
 #include "components/autofill/core/browser/autofill_manager.h"
 #include "components/autofill/core/browser/autofill_test_utils.h"
 #include "components/autofill/core/browser/payments/payments_client.h"
 #include "components/autofill/core/browser/personal_data_manager.h"
 #include "components/autofill/core/browser/test_autofill_client.h"
 #include "components/autofill/core/browser/test_autofill_driver.h"
 #include "components/autofill/core/browser/webdata/autofill_webdata_service.h"
+#include "components/autofill/core/common/autofill_l10n_util.h"
 #include "components/autofill/core/common/autofill_pref_names.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "components/rappor/test_rappor_service.h"
 #include "components/signin/core/browser/account_tracker_service.h"
 #include "components/signin/core/browser/fake_signin_manager.h"
 #include "components/signin/core/browser/test_signin_client.h"
 #include "components/signin/core/common/signin_pref_names.h"
 #include "components/webdata/common/web_data_results.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/icu/source/common/unicode/locid.h"
 #include "ui/gfx/geometry/rect.h"
 #include "url/gurl.h"
 
 using base::ASCIIToUTF16;
 using base::Bucket;
 using base::TimeTicks;
 using rappor::TestRapporService;
 using ::testing::ElementsAre;
+using icu::Locale;
 
 namespace autofill {
 namespace {
 
 class TestPersonalDataManager : public PersonalDataManager {
  public:
   TestPersonalDataManager()
       : PersonalDataManager("en-US"),
         autofill_enabled_(true) {
     CreateTestAutofillProfiles(&web_profiles_);
@@ skipping 3130 matching lines @@
   autofill_manager_->SubmitForm(fourth_form, TimeTicks::FromInternalValue(17));
   histogram_tester.ExpectBucketCount("Autofill.ProfileActionOnFormSubmitted",
                                      AutofillMetrics::NEW_PROFILE_CREATED, 2);
   histogram_tester.ExpectBucketCount("Autofill.ProfileActionOnFormSubmitted",
                                      AutofillMetrics::EXISTING_PROFILE_USED, 1);
   histogram_tester.ExpectBucketCount("Autofill.ProfileActionOnFormSubmitted",
                                      AutofillMetrics::EXISTING_PROFILE_UPDATED,
                                      1);
 }
 
+// Test the success in the creation of the ICU Collator.
+TEST_F(AutofillMetricsTest, IcuCollatorCreationSuccess) {
+  base::HistogramTester histogram_tester;
+  l10n::CaseInsensitiveCompare compare;
+  histogram_tester.ExpectUniqueSample("Autofill.IcuCollatorCreationSuccess",
+                                      true, 1);
+}
+
+// Test the failure in creating the ICU Collator.
+TEST_F(AutofillMetricsTest, IcuCollatorCreationSuccess_BadLocale) {
+  // Setting the locale to a bogus value.
+  Locale bogusLocale = Locale::createFromName("garbage");
+  bogusLocale.setToBogus();
+
+  base::HistogramTester histogram_tester;
+  l10n::CaseInsensitiveCompare compare(bogusLocale);

[Ilya Sherman, 2015/11/19 22:31:20]

Rather than creating a test-only constructor, could you please call setDefault()
(and restore the default after the test)?

[Mathieu, 2015/11/20 16:19:38]

It was my first thought as well. I tried to call setDefault with a bogus locale,
but unfortunately setDefault appears to guard against this and the next call to
getDefault returns the system default and not the bogus one. 

+  histogram_tester.ExpectUniqueSample("Autofill.IcuCollatorCreationSuccess",
+                                      false, 1);
+}
+
 // Test class that shares setup code for testing ParseQueryResponse.
 class AutofillMetricsParseQueryResponseTest : public testing::Test {
  public:
   void SetUp() override {
     FormData form;
     form.origin = GURL("http://foo.com");
     FormFieldData field;
     field.form_control_type = "text";
 
     field.label = ASCIIToUTF16("fullname");
@@ skipping 120 matching lines @@
   EXPECT_THAT(
       histogram_tester.GetAllSamples("Autofill.ServerResponseHasDataForForm"),
       ElementsAre(Bucket(true, 2)));
 
   // No RAPPOR metrics are logged in the case there is at least some server data
   // available for all forms.
   EXPECT_EQ(0, rappor_service_.GetReportsCount());
 }
 
 }  // namespace autofill