Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1457383006: MD Settings: Lazy create fonts page (Closed)

Created:
5 years, 1 month ago by michaelpg
Modified:
5 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Lazy create fonts page Save creation of ~1000 <paper-item>s (actual number probably depends on OS) until the fonts page is opened. This is just a quick-and-dirty solution which shaves off a few seconds of load time, hopefully making tests less flaky. BUG=531786 Committed: https://crrev.com/0641afa5733eb53b4767384a9f1fd507744a0b63 Cr-Commit-Position: refs/heads/master@{#360995}

Patch Set 1 #

Total comments: 2

Patch Set 2 : private #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.js View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Dan Beam
lgtm https://codereview.chromium.org/1457383006/diff/1/chrome/browser/resources/settings/appearance_page/appearance_page.js File chrome/browser/resources/settings/appearance_page/appearance_page.js (right): https://codereview.chromium.org/1457383006/diff/1/chrome/browser/resources/settings/appearance_page/appearance_page.js#newcode102 chrome/browser/resources/settings/appearance_page/appearance_page.js:102: nit: /** @private */
5 years, 1 month ago (2015-11-21 01:35:59 UTC) #3
michaelpg
https://codereview.chromium.org/1457383006/diff/1/chrome/browser/resources/settings/appearance_page/appearance_page.js File chrome/browser/resources/settings/appearance_page/appearance_page.js (right): https://codereview.chromium.org/1457383006/diff/1/chrome/browser/resources/settings/appearance_page/appearance_page.js#newcode102 chrome/browser/resources/settings/appearance_page/appearance_page.js:102: On 2015/11/21 01:35:59, Dan Beam wrote: > nit: /** ...
5 years, 1 month ago (2015-11-21 01:38:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457383006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457383006/20001
5 years, 1 month ago (2015-11-21 01:40:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/134138)
5 years, 1 month ago (2015-11-21 02:36:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457383006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457383006/20001
5 years, 1 month ago (2015-11-21 02:48:12 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-21 03:27:30 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 03:28:16 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0641afa5733eb53b4767384a9f1fd507744a0b63
Cr-Commit-Position: refs/heads/master@{#360995}

Powered by Google App Engine
This is Rietveld 408576698