services/nfc_message_sink/nfc_message_sink.mojom - Issue 1457383005: Require an explicit ServiceName annotation for interfaces in Java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/nfc_message_sink/nfc_message_sink.mojom

Issue 1457383005: Require an explicit ServiceName annotation for interfaces in Java (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Follow review Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/nfc_message_sink/nfc_message_sink.mojom

diff --git a/services/nfc_message_sink/nfc_message_sink.mojom b/services/nfc_message_sink/nfc_message_sink.mojom

index d7adb85248ad0fe6ec85e68e1f77a529b5e8f4af..e0c05982d5b6d1dec0edbd1092fc67f9eb9bd7c9 100644

--- a/services/nfc_message_sink/nfc_message_sink.mojom

+++ b/services/nfc_message_sink/nfc_message_sink.mojom

@@ -8,6 +8,7 @@ module nfc_message_sink;

// Private interface for the shell. When the shell connects to |Nfc| this

// interface will be returned which can be used to send NFC data to registered

// apps.

+[ServiceName="nfc_message_sink::NfcMessageSink"]

interface NfcMessageSink {

OnNfcMessage(array<uint8> data);

};