mojo/public/java/application/src/org/chromium/mojo/application/ShellHelper.java - Issue 1457383005: Require an explicit ServiceName annotation for interfaces in Java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/java/application/src/org/chromium/mojo/application/ShellHelper.java

Issue 1457383005: Require an explicit ServiceName annotation for interfaces in Java (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Follow review Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/interfaces/bindings/tests/sample_factory.mojom ('k') | mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/java/application/src/org/chromium/mojo/application/ShellHelper.java

diff --git a/mojo/public/java/application/src/org/chromium/mojo/application/ShellHelper.java b/mojo/public/java/application/src/org/chromium/mojo/application/ShellHelper.java

index 705e22e12c1b9ff6f339130782993da2896a4bf9..c26b37ba0aaf15417c84cab08f850fc4fb61247c 100644

--- a/mojo/public/java/application/src/org/chromium/mojo/application/ShellHelper.java

+++ b/mojo/public/java/application/src/org/chromium/mojo/application/ShellHelper.java

@@ -22,12 +22,12 @@ public class ShellHelper {

* @param core Implementation of the {@link Core} api.

* @param shell Instance of the shell.

* @param application URL to the application to use.

- * @param manager {@link org.chromium.mojo.bindings.Interface.Manager} for the service to

+ * @param manager {@link org.chromium.mojo.bindings.Interface.NamedManager} for the service to

* connect to.

* @return a proxy to the service.

public static <I extends Interface, P extends Proxy> P connectToService(

- Core core, Shell shell, String application, Interface.Manager<I, P> manager) {

+ Core core, Shell shell, String application, Interface.NamedManager<I, P> manager) {

Pair<ServiceProvider.Proxy, InterfaceRequest<ServiceProvider>> providerRequest =

ServiceProvider.MANAGER.getInterfaceRequest(core);

try (ServiceProvider.Proxy provider = providerRequest.first) {