Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1457383003: Alternative fix for the js-interop crash. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index 0945568cfec8ca52f74c4eecf1ca669123a40266..c039418c4414e4e4024eecd624db28f8064ee038 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -5938,12 +5938,11 @@ class SsaBuilder extends ast.Visitor
}
}
+ DartType type = backend.helpers.jsJavaScriptObjectClass.thisType;
var nativeBehavior = new native.NativeBehavior()
..codeTemplate = codeTemplate
- ..typesReturned.add(
- helpers.jsJavaScriptObjectClass.thisType)
- ..typesInstantiated.add(
- helpers.jsJavaScriptObjectClass.thisType)
+ ..typesReturned.add(type)
+ ..typesInstantiated.add(type)
..sideEffects.setAllSideEffects();
return new HForeignCode(
codeTemplate,

Powered by Google App Engine
This is Rietveld 408576698