third_party/WebKit/Source/core/style/BorderValue.h - Issue 1457323004: Don't render border images when border-style is none

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/BorderValue.h

Issue 1457323004: Don't render border images when border-style is none (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased, removed unnecessary border colors, etc. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/style/BorderValue.h

diff --git a/third_party/WebKit/Source/core/style/BorderValue.h b/third_party/WebKit/Source/core/style/BorderValue.h

index 1713110cf47c567fb45f7334f7687ebf57ec759f..b08f5130da13bb6d5837cf4f7f5092498e823f91 100644

--- a/third_party/WebKit/Source/core/style/BorderValue.h

+++ b/third_party/WebKit/Source/core/style/BorderValue.h

@@ -45,9 +45,9 @@ public:

{

}

- bool nonZero(bool checkStyle = true) const

+ bool nonZero() const

{

- return width() && (!checkStyle || m_style != BNONE);

+ return width() && (m_style != BNONE);

}

bool isTransparent() const

@@ -55,9 +55,9 @@ public:

return !m_colorIsCurrentColor && !m_color.alpha();

}

- bool isVisible(bool checkStyle = true) const

+ bool isVisible() const

{

- return nonZero(checkStyle) && !isTransparent() && (!checkStyle || m_style != BHIDDEN);

+ return nonZero() && !isTransparent() && (m_style != BHIDDEN);

}

bool operator==(const BorderValue& o) const

« no previous file with comments | « third_party/WebKit/Source/core/style/BorderData.h ('k') | no next file » | no next file with comments »