third_party/WebKit/LayoutTests/fast/borders/border-image-should-not-display.html - Issue 1457323004: Don't render border images when border-style is none

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/borders/border-image-should-not-display.html

Issue 1457323004: Don't render border images when border-style is none (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/borders/border-image-01.html ('K') | « third_party/WebKit/LayoutTests/fast/borders/border-image-scrambled.html ('k') | third_party/WebKit/LayoutTests/fast/borders/border-image-should-not-display-expected.html » ('j') | third_party/WebKit/Source/core/style/BorderData.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <style>
	Timothy Loh 2015/11/23 06:23:19 <!doctype html> is preferred <!doctype html> is preferred
	2 div {

	3 background-color: green;

	4 width: 100px;

	5 height: 100px;

	6 #If border style is not set (default is None), border-image
	Timothy Loh 2015/11/23 06:23:19 CSS comments are written with /* .. / syntax. CSS comments are written with / .. */ syntax.
	7 #should be ignored.

	8 #border-style: solid;

	9 }

	10

	11 #borderimg1 {
	Timothy Loh 2015/11/23 06:23:19 Since you only have one div, just put all the styl Since you only have one div, just put all the styling in the div { .. } and don't use an id.
	12 -webkit-border-image: url(red.png) 30 round;
	Timothy Loh 2015/11/23 06:23:19 no need for the prefixed property no need for the prefixed property
	13 border-image: url(resources/red.png) 30 round;

	14 border-width: 100px;

	15 }

	16

	17 </style>

	18 <div id="borderimg1"></div>

	19

OLD	NEW