Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: src/interface-descriptors.cc

Issue 1457313002: [turbofan] Pass new.target to arguments adaptor trampoline. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ia32/interface-descriptors-ia32.cc ('k') | src/mips/interface-descriptors-mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interface-descriptors.cc
diff --git a/src/interface-descriptors.cc b/src/interface-descriptors.cc
index 297722c25576fd825c60537bedb34a0c579e7404..58396695e4a41459507cd9c1150b5dd4e5e3c97b 100644
--- a/src/interface-descriptors.cc
+++ b/src/interface-descriptors.cc
@@ -420,9 +420,8 @@ CallTrampolineDescriptor::BuildCallInterfaceDescriptorFunctionType(
Zone* zone = isolate->interface_descriptor_zone();
Type::FunctionType* function =
Type::FunctionType::New(AnyTagged(zone), Type::Undefined(), 2, zone);
- function->InitParameter(0, AnyTagged(zone)); // target
- function->InitParameter(
- 1, UntaggedIntegral32(zone)); // actual number of arguments
+ function->InitParameter(0, AnyTagged(zone)); // target
+ function->InitParameter(1, UntaggedIntegral32(zone)); // actual #arguments
return function;
}
@@ -482,13 +481,11 @@ ArgumentAdaptorDescriptor::BuildCallInterfaceDescriptorFunctionType(
Isolate* isolate, int paramater_count) {
Zone* zone = isolate->interface_descriptor_zone();
Type::FunctionType* function =
- Type::FunctionType::New(AnyTagged(zone), Type::Undefined(), 3, zone);
- function->InitParameter(0, Type::Receiver()); // JSFunction
- function->InitParameter(
- 1, UntaggedIntegral32(zone)); // actual number of arguments
- function->InitParameter(
- 2,
- UntaggedIntegral32(zone)); // expected number of arguments
+ Type::FunctionType::New(AnyTagged(zone), Type::Undefined(), 4, zone);
+ function->InitParameter(0, Type::Receiver()); // JSFunction
+ function->InitParameter(1, AnyTagged(zone)); // the new target
+ function->InitParameter(2, UntaggedIntegral32(zone)); // actual #arguments
+ function->InitParameter(3, UntaggedIntegral32(zone)); // expected #arguments
return function;
}
@@ -499,12 +496,11 @@ ApiFunctionDescriptor::BuildCallInterfaceDescriptorFunctionType(
Zone* zone = isolate->interface_descriptor_zone();
Type::FunctionType* function =
Type::FunctionType::New(AnyTagged(zone), Type::Undefined(), 5, zone);
- function->InitParameter(0, AnyTagged(zone)); // callee
- function->InitParameter(1, AnyTagged(zone)); // call_data
- function->InitParameter(2, AnyTagged(zone)); // holder
- function->InitParameter(3, ExternalPointer(zone)); // api_function_address
- function->InitParameter(
- 4, UntaggedIntegral32(zone)); // actual number of arguments
+ function->InitParameter(0, AnyTagged(zone)); // callee
+ function->InitParameter(1, AnyTagged(zone)); // call_data
+ function->InitParameter(2, AnyTagged(zone)); // holder
+ function->InitParameter(3, ExternalPointer(zone)); // api_function_address
+ function->InitParameter(4, UntaggedIntegral32(zone)); // actual #arguments
return function;
}
« no previous file with comments | « src/ia32/interface-descriptors-ia32.cc ('k') | src/mips/interface-descriptors-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698