Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1457313002: [turbofan] Pass new.target to arguments adaptor trampoline. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Pass new.target to arguments adaptor trampoline. This changes the interface descriptor for the arguments adaptor to also contain an explicit register for the new.target value. Note that the stub still clobbers the register for now. This is a preparatory CL to allows us passing new.target in a register instead of via a side-channel through the construct stub frame. R=bmeurer@chromium.org BUG=v8:4544 LOG=n Committed: https://crrev.com/c0356f1f6dceaff35e8aca1ab0709de0ba6d4b7a Cr-Commit-Position: refs/heads/master@{#32117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -26 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/interface-descriptors.cc View 3 chunks +12 lines, -16 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-19 14:18:29 UTC) #1
Benedikt Meurer
Nice. LGTM.
5 years, 1 month ago (2015-11-19 14:19:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457313002/1
5 years, 1 month ago (2015-11-19 14:22:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 14:36:44 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 14:37:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0356f1f6dceaff35e8aca1ab0709de0ba6d4b7a
Cr-Commit-Position: refs/heads/master@{#32117}

Powered by Google App Engine
This is Rietveld 408576698