Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 14573012: Refactor GpuDataManagerImpl to make it thread-safe. (Closed)

Created:
7 years, 7 months ago by Zhenyao Mo
Modified:
4 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Refactor GpuDataManagerImpl to make it thread-safe. Try to reland after linux build fix. The original review is in https://codereview.chromium.org/14981007/ and https://codereview.chromium.org/14794006/. BUG=232556 TBR=kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200131

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1974 lines, -1610 lines) Patch
M content/browser/gpu/gpu_data_manager_impl.h View 3 chunks +36 lines, -127 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 2 chunks +102 lines, -811 lines 0 comments Download
A content/browser/gpu/gpu_data_manager_impl_private.h View 1 chunk +239 lines, -0 lines 0 comments Download
A content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +925 lines, -0 lines 0 comments Download
A content/browser/gpu/gpu_data_manager_impl_private_unittest.cc View 1 1 chunk +662 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_unittest.cc View 1 chunk +0 lines, -656 lines 0 comments Download
M content/browser/gpu/gpu_internals_ui.cc View 5 chunks +4 lines, -15 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/gpu_data_manager_observer.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Zhenyao Mo
patch set 1 is already reviewed and landed, but got reverted due to linux build ...
7 years, 7 months ago (2013-05-15 00:34:00 UTC) #1
Zhenyao Mo
Ken, sorry this CL took so many rounds, but please have another look at the ...
7 years, 7 months ago (2013-05-15 00:34:51 UTC) #2
Ken Russell (switch to Gerrit)
lgtm
7 years, 7 months ago (2013-05-15 00:37:56 UTC) #3
Zhenyao Mo
Committed patchset #2 manually as r200131 (presubmit successful).
7 years, 7 months ago (2013-05-15 01:06:51 UTC) #4
theoe1985
4 years, 5 months ago (2016-07-08 14:31:21 UTC) #6
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698