Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 145723011: Add a specialized apps::NativeAppWindow for app_shell (Closed)

Created:
6 years, 10 months ago by James Cook
Modified:
6 years, 10 months ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Add a specialized apps::NativeAppWindow for app_shell ShellNativeAppWindow is a minimal views-based v2 app window. It is always centered, cannot be resized, and has no frame. However, it can be created without src/chrome dependencies. This allows app_shell to open an app window using chrome.app.window.create() BUG=341251 TEST=existing browser_tests of apps

Patch Set 1 #

Patch Set 2 : similarity #

Total comments: 1

Patch Set 3 : rebase #

Patch Set 4 : android, chromeos (app_window) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+797 lines, -9 lines) Patch
apps/apps.gypi View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
apps/apps_client.h View 2 chunks +13 lines, -0 lines 0 comments Download
apps/shell/browser/shell_apps_client.h View 1 chunk +44 lines, -0 lines 0 comments Download
apps/shell/browser/shell_apps_client.cc View 1 chunk +42 lines, -0 lines 0 comments Download
apps/shell/browser/shell_browser_main_parts.h View 2 chunks +2 lines, -0 lines 0 comments Download
apps/shell/browser/shell_browser_main_parts.cc View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
apps/shell/browser/shell_extension_system.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
apps/shell/browser/shell_extension_system.cc View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
apps/shell/browser/shell_native_app_window.h View 1 1 chunk +148 lines, -0 lines 0 comments Download
apps/shell/browser/shell_native_app_window.cc View 1 chunk +341 lines, -0 lines 0 comments Download
apps/shell/browser/shell_shell_window_delegate.h View 1 chunk +57 lines, -0 lines 0 comments Download
apps/shell/browser/shell_shell_window_delegate.cc View 1 chunk +82 lines, -0 lines 0 comments Download
apps/shell_window.cc View 4 chunks +3 lines, -3 lines 0 comments Download
chrome/browser/apps/chrome_apps_client.h View 1 chunk +5 lines, -3 lines 0 comments Download
chrome/browser/apps/chrome_apps_client.cc View 1 2 3 3 chunks +31 lines, -0 lines 0 comments Download
chrome/browser/extensions/api/app_window/app_window_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
chrome/test/base/testing_browser_process.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
James Cook
benwells, PTAL I kept the awful ShellShellWindowDelegate name for now. I figure I can fix ...
6 years, 10 months ago (2014-02-13 01:13:35 UTC) #1
benwells
6 years, 10 months ago (2014-02-14 06:53:25 UTC) #2
On 2014/02/13 01:13:35, James Cook wrote:
> benwells, PTAL
> 
> I kept the awful ShellShellWindowDelegate name for now. I figure I can fix it
> when I rename ShellWindow to AppWindow -- it seemed bad to mix the two names.
> 
> https://codereview.chromium.org/145723011/diff/20001/apps/apps_client.h
> File apps/apps_client.h (right):
> 
>
https://codereview.chromium.org/145723011/diff/20001/apps/apps_client.h#newco...
> apps/apps_client.h:36: virtual ShellWindow* CreateShellWindow(
> I really only need the delegate, but I elected to return ShellWindow because
it
> can be forward declared. I can extract ShellWindow::Delegate to its own class,
> but that will also require extracting ShellWindow::CreateParams to its own
class
> and doing that felt a little big for this CL.

Sorry I've been so slow to look at this. I'm getting the old 'old chunk
mismatch' problem when I look at the diffs...

Powered by Google App Engine
This is Rietveld 408576698