Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 145723007: Fix a problem with hiDPI filters vs tiled SkPicture playback. (Closed)

Created:
6 years, 10 months ago by Stephen White
Modified:
6 years, 10 months ago
Reviewers:
Justin Novosad
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix a problem with scaled filters in tiled SkPicture playback. The matrix used during filter application should be up-to-date, so that the filter parameters can be scaled by the CTM (e.g., for hiDPI). However, tiled playback defers setting of the matrix until after the restore() call which draws the filter, which is too late. Moving the setMatrix() ahead of the restore() sequence fixes the problem. TEST=ImageFilterMatrixTest R=junov@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=13331

Patch Set 1 #

Patch Set 2 : @*&$&#$^ codereview #

Total comments: 1

Patch Set 3 : Fix 100-cols #

Patch Set 4 : Fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -1 line) Patch
M src/core/SkPictureStateTree.cpp View 2 chunks +1 line, -1 line 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 3 3 chunks +69 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Stephen White
junov@: PTAL. Thanks!
6 years, 10 months ago (2014-02-05 22:18:09 UTC) #1
Justin Novosad
On 2014/02/05 22:18:09, Stephen White wrote: > junov@: PTAL. Thanks! upload fail :-(
6 years, 10 months ago (2014-02-05 22:29:51 UTC) #2
Stephen White
On 2014/02/05 22:29:51, junov wrote: > On 2014/02/05 22:18:09, Stephen White wrote: > > junov@: ...
6 years, 10 months ago (2014-02-05 22:32:21 UTC) #3
Justin Novosad
lgtm with nit https://codereview.chromium.org/145723007/diff/100001/tests/ImageFilterTest.cpp File tests/ImageFilterTest.cpp (right): https://codereview.chromium.org/145723007/diff/100001/tests/ImageFilterTest.cpp#newcode70 tests/ImageFilterTest.cpp:70: }; no need for semi-colon
6 years, 10 months ago (2014-02-05 22:33:14 UTC) #4
Stephen White
6 years, 10 months ago (2014-02-05 22:36:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r13331 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698