Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: src/bootstrapper.cc

Issue 1457223004: Remove unused descriptor slack from strict functions to avoid breaking initial map descriptor shari… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/bootstrapper.h" 5 #include "src/bootstrapper.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api-natives.h" 8 #include "src/api-natives.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/extensions/externalize-string-extension.h" 10 #include "src/extensions/externalize-string-extension.h"
(...skipping 579 matching lines...) Expand 10 before | Expand all | Expand 10 after
590 590
591 // ES6 draft 03-17-2015, section 8.2.2 step 12 591 // ES6 draft 03-17-2015, section 8.2.2 step 12
592 AddRestrictedFunctionProperties(empty_function_map); 592 AddRestrictedFunctionProperties(empty_function_map);
593 593
594 return empty_function; 594 return empty_function;
595 } 595 }
596 596
597 597
598 void Genesis::SetStrictFunctionInstanceDescriptor(Handle<Map> map, 598 void Genesis::SetStrictFunctionInstanceDescriptor(Handle<Map> map,
599 FunctionMode function_mode) { 599 FunctionMode function_mode) {
600 int size = IsFunctionModeWithPrototype(function_mode) ? 5 : 4; 600 int size = IsFunctionModeWithPrototype(function_mode) ? 3 : 2;
601 Map::EnsureDescriptorSlack(map, size); 601 Map::EnsureDescriptorSlack(map, size);
602 602
603 PropertyAttributes rw_attribs = 603 PropertyAttributes rw_attribs =
604 static_cast<PropertyAttributes>(DONT_ENUM | DONT_DELETE); 604 static_cast<PropertyAttributes>(DONT_ENUM | DONT_DELETE);
605 PropertyAttributes ro_attribs = 605 PropertyAttributes ro_attribs =
606 static_cast<PropertyAttributes>(DONT_ENUM | DONT_DELETE | READ_ONLY); 606 static_cast<PropertyAttributes>(DONT_ENUM | DONT_DELETE | READ_ONLY);
607 PropertyAttributes roc_attribs = 607 PropertyAttributes roc_attribs =
608 static_cast<PropertyAttributes>(DONT_ENUM | READ_ONLY); 608 static_cast<PropertyAttributes>(DONT_ENUM | READ_ONLY);
609 609
610 if (function_mode == BOUND_FUNCTION) { 610 if (function_mode == BOUND_FUNCTION) {
(...skipping 2666 matching lines...) Expand 10 before | Expand all | Expand 10 after
3277 } 3277 }
3278 3278
3279 3279
3280 // Called when the top-level V8 mutex is destroyed. 3280 // Called when the top-level V8 mutex is destroyed.
3281 void Bootstrapper::FreeThreadResources() { 3281 void Bootstrapper::FreeThreadResources() {
3282 DCHECK(!IsActive()); 3282 DCHECK(!IsActive());
3283 } 3283 }
3284 3284
3285 } // namespace internal 3285 } // namespace internal
3286 } // namespace v8 3286 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698