Make WebContentsImpl aware of all of its RWHs.

content/browser/renderer_host/render_widget_host_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 21 matching lines @@
 class RenderWidgetHostInputEventRouter;
 struct NativeWebKeyboardEvent;
 
 //
 // RenderWidgetHostDelegate
 //
 //  An interface implemented by an object interested in knowing about the state
 //  of the RenderWidgetHost.
 class CONTENT_EXPORT RenderWidgetHostDelegate {
  public:
+  // The RenderWidgetHost has just been created.
+  virtual void RenderWidgetCreated(RenderWidgetHostImpl* render_widget_host) {}

[Charlie Reis, 2015/11/20 18:41:41]

There's some potential confusion here around the name (RenderWidgetCreated vs
RenderWidgetHostCreated).  I won't ask you to fix it here, since it applies to
the methods below as well.  Nasko/Nick/Avi, we should probably rename all these
in a separate CL?

The concern is that we have methods in WebContentsObserver like
RenderFrameCreated which very explicitly mean the RenderFrame and not the
RenderFrameHost.  This is thus a bit confusing (and even inconsistent below:
RenderWidgetGotFocus and RenderWidgetWasResized have comments that disagree,
though I'm not sure if it's intentional).

[Avi (use Gerrit), 2015/11/20 19:06:30]

Yeah. We've been super casual here in the past, and I'm certain it's bitten us
in ways we weren't aware of. (As a point of discussion, when I introduced
RenderProcessHostObserver, I was careful to name things like RenderProcessExited
vs RenderProcessHostDestroyed. The old names were
NOTIFICATION_RENDERER_PROCESS_CLOSED and
NOTIFICATION_RENDERER_PROCESS_TERMINATED, and *no one* got it right.)

[lazyboy, 2015/11/20 23:52:05]

Acknowledged.

[lazyboy, 2015/11/20 23:52:05]

Let me know if you want me to do sth for this newly added method.
i.e. rename it to RenderWidgetHostCreated.
Acknowledged.

+
   // The RenderWidgetHost is going to be deleted.
   virtual void RenderWidgetDeleted(RenderWidgetHostImpl* render_widget_host) {}
 
   // The RenderWidgetHost got the focus.
   virtual void RenderWidgetGotFocus(RenderWidgetHostImpl* render_widget_host) {}
 
   // The RenderWidget was resized.
   virtual void RenderWidgetWasResized(RenderWidgetHostImpl* render_widget_host,
                                       bool width_changed) {}
 
@@ skipping 118 matching lines @@
   virtual void ForwardCompositorProto(RenderWidgetHostImpl* render_widget_host,
                                       const std::vector<uint8_t>& proto) {}
 
  protected:
   virtual ~RenderWidgetHostDelegate() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_