|
Revert of Bind Application in renderer (patchset #15 id:280001 of https://codereview.chromium.org/1452823003/ )
Reason for revert:
This change is making hundreds of webkit_tests crash on linux_chromium_rel_ng with:
[1:1:1118/141621:108326049405:FATAL:lock.cc(32)] Check failed: owning_thread_ref_.is_null().
#0 0x00000067e2de base::debug::StackTrace::StackTrace()
#1 0x00000057a71f logging::LogMessage::~LogMessage()
#2 0x0000005eb69b base::Lock::CheckUnheldAndMark()
#3 0x000000518e1c base::Lock::Acquire()
#4 0x000000518b43 base::AutoLock::AutoLock()
#5 0x0000005b4014 base::SequenceCheckerImpl::CalledOnValidSequencedThread()
#6 0x000006f074ae IDMap<>::Lookup()
#7 0x000006f0598c content::RendererBlinkPlatformImpl::SetPlatformEventObserverForTesting()
#8 0x000008459264 content::SetMockGamepadProvider()
Original issue's description:
> Bind Application in renderer.
>
> This involved changing how we get the client handle to the renderer. In the first iteration I was passing this on the command line but that turns out not to work with the sandbox. So instead I an approach used by the Mojo-in-Chrome MojoApplication class and pass the primordial handle via Chrome IPC.
>
> I had to twiddle a bunch of BUILD.gn files in content to get this to work without crashing due to inconsistencies in how MOJO_SHELL_CLIENT was defined.
>
> R=jam@chromium.org,tsepez@chromium.org
> http://crbug.com/551253
>
> Committed: https://crrev.com/3edb97198bc5fbc22c5cf13286e8af80449ddfb9
> Cr-Commit-Position: refs/heads/master@{#360293}
>
> Committed: https://crrev.com/2c716f9d5ebff610641f4506c17ec81d4b89b7bb
> Cr-Commit-Position: refs/heads/master@{#360396}
TBR=jam@chromium.org,tsepez@chromium.org,ben@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/1b3bd8ec1752e2c0442746c0f1f60e693601b4f2
Cr-Commit-Position: refs/heads/master@{#360446}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+116 lines, -250 lines) |
Patch |
 |
M |
components/mus/example/window_type_launcher/main.cc
|
View
|
|
1 chunk |
+7 lines, -5 lines |
0 comments
|
Download
|
 |
M |
content/app/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/BUILD.gn
|
View
|
|
2 chunks |
+2 lines, -8 lines |
0 comments
|
Download
|
 |
M |
content/browser/child_process_launcher.cc
|
View
|
|
4 chunks |
+59 lines, -0 lines |
0 comments
|
Download
|
 |
D |
content/browser/mojo/mojo_shell_client_host.h
|
View
|
|
1 chunk |
+0 lines, -27 lines |
0 comments
|
Download
|
 |
D |
content/browser/mojo/mojo_shell_client_host.cc
|
View
|
|
1 chunk |
+0 lines, -72 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_process_host_impl.cc
|
View
|
|
2 chunks |
+0 lines, -10 lines |
0 comments
|
Download
|
 |
M |
content/child/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
content/child/child_thread_impl.h
|
View
|
|
3 chunks |
+0 lines, -12 lines |
0 comments
|
Download
|
 |
M |
content/child/child_thread_impl.cc
|
View
|
|
3 chunks |
+0 lines, -23 lines |
0 comments
|
Download
|
 |
M |
content/common/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/common/mojo/mojo_messages.h
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
content/common/mojo/mojo_shell_connection_impl.h
|
View
|
|
4 chunks |
+3 lines, -6 lines |
0 comments
|
Download
|
 |
M |
content/common/mojo/mojo_shell_connection_impl.cc
|
View
|
|
1 chunk |
+4 lines, -11 lines |
0 comments
|
Download
|
 |
M |
content/gpu/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
content/plugin/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
content/ppapi_plugin/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
content/public/browser/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/public/common/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
M |
content/public/renderer/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
content/renderer/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/test/BUILD.gn
|
View
|
|
2 chunks |
+1 line, -5 lines |
0 comments
|
Download
|
 |
M |
content/utility/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
mojo/runner/child/runner_connection.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
mojo/runner/child/runner_connection.cc
|
View
|
|
7 chunks |
+27 lines, -24 lines |
0 comments
|
Download
|
 |
M |
mojo/runner/child/test_native_main.cc
|
View
|
|
1 chunk |
+5 lines, -3 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|