Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 1457113002: Add underscore to local variables in "process_java_prebuilt" and "compile_java" templates (Closed)

Created:
5 years, 1 month ago by pkotwicz
Modified:
5 years, 1 month ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add underscore to local variables in "process_java_prebuilt" and "compile_java" templates This CL makes the "process_java_prebuilt" and "compile_java" templates follow the convention: "Local variables in a template should be prefixed with an underscore" BUG=535290 Committed: https://crrev.com/c79f5d4de76cd15fe59be6c24e8bec7c48a3f11f Cr-Commit-Position: refs/heads/master@{#360608}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M build/config/android/internal_rules.gni View 9 chunks +26 lines, -26 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
pkotwicz
Andrew, can you please take a look?
5 years, 1 month ago (2015-11-18 21:47:41 UTC) #6
agrieve
On 2015/11/18 21:47:41, pkotwicz wrote: > Andrew, can you please take a look? lgtm
5 years, 1 month ago (2015-11-19 01:22:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457113002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457113002/80001
5 years, 1 month ago (2015-11-19 16:22:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:80001)
5 years, 1 month ago (2015-11-19 17:03:58 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 17:04:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c79f5d4de76cd15fe59be6c24e8bec7c48a3f11f
Cr-Commit-Position: refs/heads/master@{#360608}

Powered by Google App Engine
This is Rietveld 408576698