chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc - Issue 14571003: Don't display drop down arrows in rAc dialog unless there is a suggestion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc

Issue 14571003: Don't display drop down arrows in rAc dialog unless there is a suggestion (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update tests Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_dialog_controller.h » ('j') | chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc

diff --git a/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc b/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc

index c29a1d33959c6f7d7bf140b06115d421f886450c..35fdb1b98374238b20dbd9369dc2ab3303e86daf 100644

--- a/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc

+++ b/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc

@@ -146,7 +146,7 @@ void AutofillDialogViewAndroid::UpdateSection(DialogSection section) {

}

ui::MenuModel* menuModel = controller_->MenuModelForSection(section);

- const int itemCount = menuModel->GetItemCount();

+ const int itemCount = menuModel ? menuModel->GetItemCount() : 0;

ScopedJavaLocalRef<jobjectArray> menu_array =

Java_AutofillDialogGlue_createAutofillDialogMenuItemArray(env,

itemCount);

« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_dialog_controller.h » ('j') | chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc » ('J')