Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 145703002: A64: fix ProfileEntryHookStub to pass return address location. (Closed)

Created:
6 years, 11 months ago by ulan
Modified:
6 years, 11 months ago
Reviewers:
Rodolph Perfetta
CC:
v8-dev
Visibility:
Public.

Description

A64: fix ProfileEntryHookStub to pass return address location. BUG=314606 TEST=cctest/test-api/SetFunctionEntryHook R=rodolph.perfetta@gmail.com Committed: https://code.google.com/p/v8/source/detail?r=18782

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/a64/code-stubs-a64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL, the entry hook expects location of the return address, but we are passing the ...
6 years, 11 months ago (2014-01-23 14:31:25 UTC) #1
Rodolph Perfetta
lgtm
6 years, 11 months ago (2014-01-23 14:42:39 UTC) #2
ulan
6 years, 11 months ago (2014-01-23 14:59:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18782 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698