Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1457013002: Lock page scale factor in tall-content-short-columns performance tests (Closed)

Created:
5 years, 1 month ago by Kevin McNee - google account
Modified:
5 years, 1 month ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lock page scale factor in tall-content-short-columns performance tests During the tests, the changes to the content width cause the page scale factor to be changed to fit the content. We lock the page scale factor to prevent this from happening and impacting performance. The performance regression is caused by the sending of notifications upon all changes to page scale factor whereas previously, these notifications would not have been sent. See https://codereview.chromium.org/1408393003/ where this behaviour was changed. BUG=555151 Committed: https://crrev.com/7030b20ca8a7a9868bf57341fbe55b28ad3ee6be Cr-Commit-Position: refs/heads/master@{#360596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/PerformanceTests/Layout/multicol/tall-content-short-columns.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/multicol/tall-content-short-columns-realistic.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
Kevin McNee - google account
5 years, 1 month ago (2015-11-18 18:03:09 UTC) #3
Kevin McNee - google account
dsinclair@: Hello. Could you take a look at this change?
5 years, 1 month ago (2015-11-18 18:18:21 UTC) #5
dsinclair
mstensho@ as the multi-col expert.
5 years, 1 month ago (2015-11-18 18:22:09 UTC) #7
mstensho (USE GERRIT)
lgtm
5 years, 1 month ago (2015-11-18 20:01:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457013002/1
5 years, 1 month ago (2015-11-18 20:10:13 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/142633)
5 years, 1 month ago (2015-11-18 21:07:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457013002/1
5 years, 1 month ago (2015-11-18 21:36:50 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/142728)
5 years, 1 month ago (2015-11-18 22:53:03 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457013002/1
5 years, 1 month ago (2015-11-19 14:24:32 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 16:18:02 UTC) #21
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 16:18:45 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7030b20ca8a7a9868bf57341fbe55b28ad3ee6be
Cr-Commit-Position: refs/heads/master@{#360596}

Powered by Google App Engine
This is Rietveld 408576698