Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 14570003: Add url.gyp:* to All target. (Closed)

Created:
7 years, 7 months ago by tfarina
Modified:
7 years, 7 months ago
Reviewers:
iannucci, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Add url.gyp:* to All target. Previously we have googleurl_unittests in googleurl.gyp, but that isn't more the case when it was moved into url.gyp and made just a copy of url_unittests. To actually get back the googlurl_unittests target we need to also add url.gyp to All target. This should fix the following error on ios build: common.chromium_utils.PathNotFound: Unable to find /b/build/slave/ios_dbg_simulator/build/src/xcodebuild/Debug-iphonesimulator/googleurl_unittests.app BUG=229660 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
Nico, Robbie, please, check if this is the right thing to do. Thanks,
7 years, 7 months ago (2013-05-01 01:23:09 UTC) #1
Nico
Do you have a link to the ios build output? Which targets does it build?
7 years, 7 months ago (2013-05-01 03:04:51 UTC) #2
Nico
(this CL lgtm regardless, but it'd be good to understand why exactly the ios bot ...
7 years, 7 months ago (2013-05-01 03:05:33 UTC) #3
tfarina
On 2013/05/01 03:04:51, Nico wrote: > Do you have a link to the ios build ...
7 years, 7 months ago (2013-05-01 03:13:28 UTC) #4
Nico
Ah, it just builds All. Then this is fine. On Tue, Apr 30, 2013 at ...
7 years, 7 months ago (2013-05-01 04:56:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/14570003/1
7 years, 7 months ago (2013-05-01 14:07:38 UTC) #6
tfarina
7 years, 7 months ago (2013-05-01 15:51:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r197620 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698