media::FFmpegVideoDecoder: remove ctor param |task_runner| and use a ThreadChecker instead.

media::FFmpegVideoDecoder: remove ctor param |task_runner| and use a ThreadChecker instead.

This CL removed the |task_runner| passed on construction to
FFmpegVideoDecoder since: "... is used in just one location
for PostTask()ing. The class itself is otherwise mostly single
threaded (except perhaps construction), and passing a
|task_runner| as ctor argument is confusingly indicating the
opposite. A |thread_checker_| basically tells that a(ll) methods
are run in a given thread, whichever this is."
(from discussion in http://crrev.com/1438233003, which has
sadly been reverted for unrelated issues, and is going to be
relanded as http://crrev.com/1447343004).

Removal of this |task_runner| is also necessary for using these
two classes from WebRtc, see the linekd bug.

BUG=554737
TEST=This is a tiny change, all unittest and content_browsertests should cover it.

Committed: https://crrev.com/97e43b3e9b64da825f925a047b8d91e75260fd82
Cr-Commit-Position: refs/heads/master@{#360628}

[mcasas, 2015-11-19 01:29:00]

Description was changed from

==========
media::FFmpegVideoDecoder: remove ctor param |task_runner| and use a
ThreadChecker instead.

This CL removed the |task_runner| passed on construction to
FFmpegVideoDecoder since: "... is used in just one location
for PostTask()ing. The class itself is otherwise mostly single
threaded (except perhaps construction), and passing a
|task_runner| as ctor argument is confusingly indicating the
opposite. A |thread_checker_| basically tells that a(ll) methods
are run in a given thread, whichever this is. Hmm... makes sense?"
(from discussion in http://crrev.com/1438233003, which has
sadly been reverted for unrelated issues, and is going to be
relanded as http://crrev.com/1447343004).

Removal of this |task_runner| is also necessary for using these
two classes from WebRtc, see the linekd bug.

BUG=554737

TEST=This is a tiny change, all unittest and content_browsertests should cover
it.
==========

to

==========
media::FFmpegVideoDecoder: remove ctor param |task_runner| and use a
ThreadChecker instead.

This CL removed the |task_runner| passed on construction to
FFmpegVideoDecoder since: "... is used in just one location
for PostTask()ing. The class itself is otherwise mostly single
threaded (except perhaps construction), and passing a
|task_runner| as ctor argument is confusingly indicating the
opposite. A |thread_checker_| basically tells that a(ll) methods
are run in a given thread, whichever this is."
(from discussion in http://crrev.com/1438233003, which has
sadly been reverted for unrelated issues, and is going to be
relanded as http://crrev.com/1447343004).

Removal of this |task_runner| is also necessary for using these
two classes from WebRtc, see the linekd bug.

BUG=554737

TEST=This is a tiny change, all unittest and content_browsertests should cover
it.
==========

[mcasas, 2015-11-19 01:30:23]

mcasas@chromium.org changed reviewers:
+ chcunningham@chromium.org, dalecurtis@chromium.org

[mcasas, 2015-11-19 01:30:24]

dalecurtis@/chcunningham@ PTAL

[mcasas, 2015-11-19 01:38:49]

Patchset #1 (id:1) has been deleted

[DaleCurtis, 2015-11-19 02:09:00]

Seems fine, lgtm

[mcasas, 2015-11-19 15:44:44]

mcasas@chromium.org changed reviewers:
+ bbudge@chromium.org

[mcasas, 2015-11-19 15:44:44]

bbudge@ tiny thing in content/renderer/pepper/video_decoder_shim.cc

[bbudge, 2015-11-19 17:06:04]

content/renderer/pepper lgtm

[mcasas, 2015-11-19 17:06:55]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2015-11-19 17:07:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456993004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456993004/20001

[commit-bot: I haz the power, 2015-11-19 18:21:39]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-11-19 18:22:44]

Patchset 1 (id:??) landed as
https://crrev.com/97e43b3e9b64da825f925a047b8d91e75260fd82
Cr-Commit-Position: refs/heads/master@{#360628}

[mcasas, 2015-11-19 20:09:48]

A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/1459163003/ by mcasas@chromium.org.

The reason for reverting is: Broke compilation in a Mac bot
(https://chromegw.corp.google.com/i/official.desktop.continuous/builders/mac%2...)
(I wonder why the CQ passed)
http://crbug.com/558587.