Move JS-related password manager code upstream

ios/chrome/browser/passwords/js_credential_manager.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CHROME_BROWSER_PASSWORDS_JS_CREDENTIAL_MANAGER_H_
+#define IOS_CHROME_BROWSER_PASSWORDS_JS_CREDENTIAL_MANAGER_H_
+
+#include "ios/web/public/web_state/credential.h"
+#import "ios/web/public/web_state/js/crw_js_injection_manager.h"
+
+namespace base {
+class DictionaryValue;
+}  // namespace base
+
+namespace ios {

[droger, 2015/11/18 16:24:17]

Remove the ios:: namespace

[vabr (Chromium), 2015/11/18 16:52:28]

Done.

+namespace passwords {

[vabr (Chromium), 2015/11/18 16:55:13]

Hm, I see you only advised against the 'ios' here, and I believe I should
actually keep the constants in a namespace, because their names are fairly
generic. Will fix that in a moment.

[droger, 2015/11/18 17:07:40]

Some people argue that we should not use any namespace in //chrome or
//ios/chrome.
See for example discussions like:
https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/namesp...

I don't have a really strong opinion.

[droger, 2015/11/18 17:11:27]

This discussion is also related:
https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/namesp...

[vabr (Chromium), 2015/11/18 17:14:06]

As an alternative I can just prefix all the names with Credentials, as in
kCredentialsPendingRequestErrorType, that should be specific enough. Will go
with that.

+// Constants for rejecting requests.
+extern const char kPendingRequestErrorType[];
+extern const char kPendingRequestErrorMessage[];
+extern const char kSecurityErrorType[];
+extern const char kPasswordStoreUnavailableErrorType[];
+extern const char kPasswordStoreUnavailableErrorMessage[];
+extern const char kSecurityErrorMessageUntrustedOrigin[];
+}  // namespace passwords
+}  // namespace ios
+
+// Injects the JavaScript that implements the request credentials API and
+// provides an app-side interface for interacting with it.
+@interface JSCredentialManager : CRWJSInjectionManager
+
+// Resolves the JavaScript Promise associated with |requestID| with the
+// specified |credential|. |completionHandler| will be invoked after the
+// operation has completed with YES if successful.
+- (void)resolvePromiseWithRequestID:(NSInteger)requestID
+                         credential:(const web::Credential&)credential
+                  completionHandler:(void (^)(BOOL))completionHandler;
+
+// Resolves the JavaScript Promise associated with |requestID|.
+// |completionHandler| will be invoked after the operation has completed with
+// YES if successful.
+- (void)resolvePromiseWithRequestID:(NSInteger)requestID
+                  completionHandler:(void (^)(BOOL))completionHandler;
+
+// Rejects the JavaScript Promise associated with |requestID| with an Error of
+// the specified |errorType| and |message|. |completionHandler| will be invoked
+// after the operation has completed with YES if successful.
+- (void)rejectPromiseWithRequestID:(NSInteger)requestID
+                         errorType:(NSString*)errorType
+                           message:(NSString*)message
+                 completionHandler:(void (^)(BOOL))completionHandler;
+
+@end
+
+#endif  // IOS_CHROME_BROWSER_PASSWORDS_JS_CREDENTIAL_MANAGER_H_