Issue 1456973002: Revert of Parametric contour start GM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1456973002: Revert of Parametric contour start GM (Closed)

Created:
5 years, 1 month ago by stephana

Modified:
5 years, 1 month ago

Reviewers:
f(malita), caryclark, reed1

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Parametric contour start GM (patchset #1 id:1 of https://codereview.chromium.org/1457503002/ ) Reason for revert: Breaks unit test across various platforms: ../../../src/gpu/batches/GrStencilAndCoverPathRenderer.cpp:75: failed assertion "path->isEqualTo(skPath, stroke)" Original issue's description: > Parametric contour start GM > > A GM to capture the newly added SkPath API. > > BUG=chromium:315277 > R=caryclark@google.com,reed@google.com > > Committed: https://skia.googlesource.com/skia/+/56847a65648af4d06da9c26c55242949a1bf31ab TBR=caryclark@google.com,reed@google.com,fmalita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:315277 Committed: https://skia.googlesource.com/skia/+/9c08b9d3f0616b24d1d378ef6212dde08112f06c

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -133 lines)			Patch
	D	gm/pathcontourstart.cpp	View		1 chunk	+0 lines, -133 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456973002/1

5 years, 1 month ago (2015-11-18 14:21:29 UTC) #2

commit-bot: I haz the power

5 years, 1 month ago (2015-11-18 14:21:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9c08b9d3f0616b24d1d378ef6212dde08112f06c

Expand Messages | Collapse Messages