Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: chrome/browser/ui/browser.h

Issue 1456963002: Make browser windows override_redirect when dragging tabs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make browser windows override_redirect when dragging tabs. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/host/ash_window_tree_host_x11.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_H_
6 #define CHROME_BROWSER_UI_BROWSER_H_ 6 #define CHROME_BROWSER_UI_BROWSER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 gfx::Rect initial_bounds; 187 gfx::Rect initial_bounds;
188 188
189 ui::WindowShowState initial_show_state; 189 ui::WindowShowState initial_show_state;
190 190
191 bool is_session_restore; 191 bool is_session_restore;
192 192
193 // Supply a custom BrowserWindow implementation, to be used instead of the 193 // Supply a custom BrowserWindow implementation, to be used instead of the
194 // default. Intended for testing. 194 // default. Intended for testing.
195 BrowserWindow* window; 195 BrowserWindow* window;
196 196
197 bool is_being_dragged;
198
197 private: 199 private:
198 friend class Browser; 200 friend class Browser;
199 201
200 // The application name that is also the name of the window to the shell. 202 // The application name that is also the name of the window to the shell.
201 // Do not set this value directly, use CreateForApp. 203 // Do not set this value directly, use CreateForApp.
202 // This name will be set for: 204 // This name will be set for:
203 // 1) v1 applications launched via an application shortcut or extension API. 205 // 1) v1 applications launched via an application shortcut or extension API.
204 // 2) undocked devtool windows. 206 // 2) undocked devtool windows.
205 // 3) popup windows spawned from v1 applications. 207 // 3) popup windows spawned from v1 applications.
206 std::string app_name; 208 std::string app_name;
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
458 bool CanDragEnter(content::WebContents* source, 460 bool CanDragEnter(content::WebContents* source,
459 const content::DropData& data, 461 const content::DropData& data,
460 blink::WebDragOperationsMask operations_allowed) override; 462 blink::WebDragOperationsMask operations_allowed) override;
461 content::SecurityStyle GetSecurityStyle( 463 content::SecurityStyle GetSecurityStyle(
462 content::WebContents* web_contents, 464 content::WebContents* web_contents,
463 content::SecurityStyleExplanations* security_style_explanations) override; 465 content::SecurityStyleExplanations* security_style_explanations) override;
464 466
465 bool is_type_tabbed() const { return type_ == TYPE_TABBED; } 467 bool is_type_tabbed() const { return type_ == TYPE_TABBED; }
466 bool is_type_popup() const { return type_ == TYPE_POPUP; } 468 bool is_type_popup() const { return type_ == TYPE_POPUP; }
467 469
470 bool is_being_dragged() const { return is_being_dragged_; }
471
468 bool is_app() const; 472 bool is_app() const;
469 bool is_devtools() const; 473 bool is_devtools() const;
470 474
471 // True when the mouse cursor is locked. 475 // True when the mouse cursor is locked.
472 bool IsMouseLocked() const; 476 bool IsMouseLocked() const;
473 477
474 // Called each time the browser window is shown. 478 // Called each time the browser window is shown.
475 void OnWindowDidShow(); 479 void OnWindowDidShow();
476 480
477 // Show the first run search engine bubble on the location bar. 481 // Show the first run search engine bubble on the location bar.
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
962 966
963 scoped_ptr<extensions::WindowController> extension_window_controller_; 967 scoped_ptr<extensions::WindowController> extension_window_controller_;
964 968
965 scoped_ptr<chrome::BrowserCommandController> command_controller_; 969 scoped_ptr<chrome::BrowserCommandController> command_controller_;
966 970
967 // True if the browser window has been shown at least once. 971 // True if the browser window has been shown at least once.
968 bool window_has_shown_; 972 bool window_has_shown_;
969 973
970 scoped_ptr<ValidationMessageBubble> validation_message_bubble_; 974 scoped_ptr<ValidationMessageBubble> validation_message_bubble_;
971 975
976 bool is_being_dragged_;
977
972 // The following factory is used for chrome update coalescing. 978 // The following factory is used for chrome update coalescing.
973 base::WeakPtrFactory<Browser> chrome_updater_factory_; 979 base::WeakPtrFactory<Browser> chrome_updater_factory_;
974 980
975 // The following factory is used to close the frame at a later time. 981 // The following factory is used to close the frame at a later time.
976 base::WeakPtrFactory<Browser> weak_factory_; 982 base::WeakPtrFactory<Browser> weak_factory_;
977 983
978 DISALLOW_COPY_AND_ASSIGN(Browser); 984 DISALLOW_COPY_AND_ASSIGN(Browser);
979 }; 985 };
980 986
981 #endif // CHROME_BROWSER_UI_BROWSER_H_ 987 #endif // CHROME_BROWSER_UI_BROWSER_H_
OLDNEW
« no previous file with comments | « ash/host/ash_window_tree_host_x11.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698