chrome/browser/ui/views/chrome_views_delegate_aura.cc - Issue 1456963002: Make browser windows override_redirect when dragging tabs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/chrome_views_delegate_aura.cc

Issue 1456963002: Make browser windows override_redirect when dragging tabs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make browser windows override_redirect when dragging tabs. Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/browser.h ('K') | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/views/frame/browser_frame.cc » ('j') | ui/aura/window_tree_host.h » ('J')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/views/chrome_views_delegate.h"	5 #include "chrome/browser/ui/views/chrome_views_delegate.h"

6	6

7 #include "chrome/browser/ui/ash/ash_util.h"	7 #include "chrome/browser/ui/ash/ash_util.h"

8	8

9 views::Widget::InitParams::WindowOpacity	9 views::Widget::InitParams::WindowOpacity

10 ChromeViewsDelegate::GetOpacityForInitParams(	10 ChromeViewsDelegate::GetOpacityForInitParams(

11 const views::Widget::InitParams& params) {	11 const views::Widget::InitParams& params) {

12 gfx::NativeView native_view = params.parent ? params.parent : params.context;	12 gfx::NativeView native_view = params.parent ? params.parent : params.context;

13 if (native_view && chrome::IsNativeViewInAsh(native_view))	13 if (native_view && chrome::IsNativeViewInAsh(native_view))

14 return views::Widget::InitParams::TRANSLUCENT_WINDOW;	14 return views::Widget::InitParams::TRANSLUCENT_WINDOW;

15	15

16 // We want translucent windows when either we are in ASH or we are	16 // We want translucent windows when either we are in ASH or we are

17 // a top level window which is not of type TYPE_WINDOW.	17 // a top level window which is not of type TYPE_WINDOW.

18 if (!params.child && params.type != views::Widget::InitParams::TYPE_WINDOW)	18 if (!params.child &&

	19 (params.type != views::Widget::InitParams::TYPE_WINDOW \|\|
	Daniel Erat 2015/12/28 21:33:02 did you mean '&&' here? "foo != A \|\| foo != B" wil did you mean '&&' here? "foo != A \|\| foo != B" will always be true. stapelberg 2016/01/18 17:22:23 Yes. In the new patchset that hunk’s no longer pre Show quoted text On 2015/12/28 21:33:02, Daniel Erat wrote: > did you mean '&&' here? "foo != A \|\| foo != B" will always be true. Yes. In the new patchset that hunk’s no longer present, though, so this is done.
	20 params.type != views::Widget::InitParams::TYPE_DRAG_BROWSER))

19 return views::Widget::InitParams::TRANSLUCENT_WINDOW;	21 return views::Widget::InitParams::TRANSLUCENT_WINDOW;

20	22

21 return views::Widget::InitParams::OPAQUE_WINDOW;	23 return views::Widget::InitParams::OPAQUE_WINDOW;

22 }	24 }

OLD	NEW