Make browser windows override_redirect when dragging tabs.

chrome/browser/ui/views/frame/browser_frame.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_frame.h"
 
 #include "base/debug/leak_annotations.h"
 #include "base/i18n/rtl.h"
 #include "chrome/browser/app_mode/app_mode_utils.h"
 #include "chrome/browser/themes/theme_service.h"
@@ skipping 50 matching lines @@
   static const gfx::FontList* title_font_list = new gfx::FontList();
   ANNOTATE_LEAKING_OBJECT_PTR(title_font_list);
   return *title_font_list;
 }
 
 void BrowserFrame::InitBrowserFrame() {
   native_browser_frame_ =
       NativeBrowserFrameFactory::CreateNativeBrowserFrame(this, browser_view_);
   views::Widget::InitParams params = native_browser_frame_->GetWidgetParams();
   params.delegate = browser_view_;
+  if (browser_view_->browser()->is_override_redirect()) {
+    params.type = views::Widget::InitParams::TYPE_DRAG_BROWSER;

[Daniel Erat, 2015/11/18 16:16:47]

it seems weird to infer this type based on the override-redirect-ness of the
browser. is there some other way to detect this?

[stapelberg, 2015/12/23 13:17:24]

Well, given that TYPE_DRAG_BROWSER is exactly TYPE_BROWSER, but with the
difference of using an undecorated frame (override-redirect), I think it’s
appropriate.

How do you suggest to solve your concern? To me, it seems like renaming either
of the two properties might be a good solution. I’m willing to do that, but I
don’t have a good suggestion. What are your thoughts?

+  }
   if (browser_view_->browser()->is_type_tabbed()) {
     // Typed panel/popup can only return a size once the widget has been
     // created.
     chrome::GetSavedWindowBoundsAndShowState(browser_view_->browser(),
                                              &params.bounds,
                                              &params.show_state);
   }
   Init(params);
 
   if (!native_browser_frame_->UsesNativeSystemMenu()) {
@@ skipping 162 matching lines @@
 
 #if defined(FRAME_AVATAR_BUTTON)
 NewAvatarButton* BrowserFrame::GetNewAvatarMenuButton() {
   return browser_frame_view_->new_avatar_button();
 }
 #endif
 
 bool BrowserFrame::ShouldLeaveOffsetNearTopBorder() {
   return !IsMaximized();
 }