Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

Issue 1456943003: Devtools: use TextRange in UISourceCode.Message, allow addMessage to take a TextRange (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: trim whitespace Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 } 171 }
172 172
173 WebInspector.PresentationConsoleMessage.prototype = { 173 WebInspector.PresentationConsoleMessage.prototype = {
174 /** 174 /**
175 * @param {!WebInspector.UILocation} uiLocation 175 * @param {!WebInspector.UILocation} uiLocation
176 */ 176 */
177 _updateLocation: function(uiLocation) 177 _updateLocation: function(uiLocation)
178 { 178 {
179 if (this._uiMessage) 179 if (this._uiMessage)
180 this._uiMessage.remove(); 180 this._uiMessage.remove();
181 this._uiMessage = uiLocation.uiSourceCode.addMessage(this._level, this._ text, uiLocation.lineNumber, uiLocation.columnNumber); 181 this._uiMessage = uiLocation.uiSourceCode.addLineMessage(this._level, th is._text, uiLocation.lineNumber, uiLocation.columnNumber);
182 }, 182 },
183 183
184 dispose: function() 184 dispose: function()
185 { 185 {
186 this._liveLocation.dispose(); 186 this._liveLocation.dispose();
187 if (this._uiMessage) 187 if (this._uiMessage)
188 this._uiMessage.remove(); 188 this._uiMessage.remove();
189 } 189 }
190 } 190 }
191 191
192 /** @type {!WebInspector.PresentationConsoleMessageHelper} */ 192 /** @type {!WebInspector.PresentationConsoleMessageHelper} */
193 WebInspector.presentationConsoleMessageHelper; 193 WebInspector.presentationConsoleMessageHelper;
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698