[FileAPI] Replace default leveldb::Env with leveldb::MemEnv in tests.

[FileAPI] Replace default leveldb::Env with leveldb::MemEnv in tests.

Use in-memory LevelDB in tests that don't test LevelDB behavior itself.

BUG=331988
R=kinuko@chromium.org, nhiroki@chromium.org, sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247631

[tzik, 2014-01-28 05:23:12]

Hi, all.
I'd replace on-disk LevelDB with on-memory one for faster test cycle.
Could you take a look?

kinuko: {content,webkit}/browser/fileapi/
nhiroki: chrome/browser/sync_file_system/
sky: content/public/test/

[kinuko, 2014-01-28 06:14:47]

On 2014/01/28 05:23:12, tzik wrote:
> Hi, all.
> I'd replace on-disk LevelDB with on-memory one for faster test cycle.
> Could you take a look?
> 
> kinuko: {content,webkit}/browser/fileapi/
> nhiroki: chrome/browser/sync_file_system/

Basically lgtm, with one request: would it be possible not to expose the
leveldb::Env parameter on the very outer SyncFileSystemService ctor?
It feels a bit weird we need to always pass in leveldb::Env (which is named
'env_override') to create the service.

> sky: content/public/test/

[tzik, 2014-01-28 06:34:11]

On 2014/01/28 06:14:47, kinuko wrote:
> On 2014/01/28 05:23:12, tzik wrote:
> > Hi, all.
> > I'd replace on-disk LevelDB with on-memory one for faster test cycle.
> > Could you take a look?
> > 
> > kinuko: {content,webkit}/browser/fileapi/
> > nhiroki: chrome/browser/sync_file_system/
> 
> Basically lgtm, with one request: would it be possible not to expose the
> leveldb::Env parameter on the very outer SyncFileSystemService ctor?
> It feels a bit weird we need to always pass in leveldb::Env (which is named
> 'env_override') to create the service.
> 
> > sky: content/public/test/

Updated!
I added Create and CreateForTesting and remove it from static constructor.

[nhiroki, 2014-01-28 07:06:59]

LGTM for chrome/browser/sync_file_system

[kinuko, 2014-01-28 07:22:26]

lgtm

[kinuko, 2014-01-28 07:22:37]

https://codereview.chromium.org/145693005/diff/100001/webkit/browser/fileapi/...
File webkit/browser/fileapi/file_system_options.h (right):

https://codereview.chromium.org/145693005/diff/100001/webkit/browser/fileapi/...
webkit/browser/fileapi/file_system_options.h:33: // |env_override| overrides
internal LevelDB environment.
nit:

Non-null |env_override| overrides..

for clarity?

[tzik, 2014-01-28 07:37:16]

https://codereview.chromium.org/145693005/diff/100001/webkit/browser/fileapi/...
File webkit/browser/fileapi/file_system_options.h (right):

https://codereview.chromium.org/145693005/diff/100001/webkit/browser/fileapi/...
webkit/browser/fileapi/file_system_options.h:33: // |env_override| overrides
internal LevelDB environment.
On 2014/01/28 07:22:38, kinuko wrote:
> nit:
> 
> Non-null |env_override| overrides..
> 
> for clarity?

Done.

[sky, 2014-01-28 15:07:02]

LGTM

https://codereview.chromium.org/145693005/diff/140001/content/public/test/tes...
File content/public/test/test_file_system_options.cc (right):

https://codereview.chromium.org/145693005/diff/140001/content/public/test/tes...
content/public/test/test_file_system_options.cc:22: };
nit: no ; here, 33 and 43.

[tzik, 2014-01-28 16:42:00]

https://codereview.chromium.org/145693005/diff/140001/content/public/test/tes...
File content/public/test/test_file_system_options.cc (right):

https://codereview.chromium.org/145693005/diff/140001/content/public/test/tes...
content/public/test/test_file_system_options.cc:22: };
On 2014/01/28 15:07:03, sky wrote:
> nit: no ; here, 33 and 43.

Done.

[commit-bot: I haz the power, 2014-01-28 18:25:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/145693005/160001

[commit-bot: I haz the power, 2014-01-28 20:12:04]

Retried try job too often on linux_rel for step(s) browser_tests,
remoting_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2014-01-29 01:18:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/145693005/160001

[commit-bot: I haz the power, 2014-01-29 03:31:23]

Retried try job too often on mac_rel for step(s) remoting_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[tzik, 2014-01-29 05:35:43]

Committed patchset #7 manually as r247631 (presubmit successful).