A64: Implement HRandom.

A64: Implement HRandom.

R=rodolph.perfetta@gmail.com

Committed: https://code.google.com/p/v8/source/detail?r=18852

[Benedikt Meurer, 2014-01-23 14:01:35]

PTAL

[ulan, 2014-01-23 14:48:08]

https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64.cc
File src/a64/lithium-codegen-a64.cc (right):

https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
src/a64/lithium-codegen-a64.cc:3578: __ cbz(w2, deferred->entry());
Use Cbz of masm.

https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
src/a64/lithium-codegen-a64.cc:3602: __ bind(deferred->exit());
Use Bind of masm.

[Rodolph Perfetta, 2014-01-23 15:02:14]

The code could be optimized with ldp/stp for the state but since this code will
disappear, it is not worth spending the time.

https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-a64.cc
File src/a64/lithium-a64.cc (right):

https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-a64.cc#newco...
src/a64/lithium-a64.cc:1256: return MarkAsCall(DefineFixedDouble(result, d7),
instr);
Use d0 to be consistent with other uses.

https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64.cc
File src/a64/lithium-codegen-a64.cc (right):

https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
src/a64/lithium-codegen-a64.cc:3560: // Having marked this instruction as a call
we can use any registers.
ASSERT(instr->IsMarkedAsCall());

https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
src/a64/lithium-codegen-a64.cc:3578: __ cbz(w2, deferred->entry());
cbz -> Cbz

https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
src/a64/lithium-codegen-a64.cc:3583: __ And(w4, w2, Operand(0xFFFF));
No need for Operand, And(w4, 0xFFFF) works.

This applies to mov and and below too.

https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
src/a64/lithium-codegen-a64.cc:3602: __ bind(deferred->exit());
bind -> Bind

https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
src/a64/lithium-codegen-a64.cc:3610: __
CallCFunction(ExternalReference::random_uint32_function(isolate()), 0);
the function takes a parameter.

[Benedikt Meurer, 2014-01-24 06:37:52]

https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64.cc
File src/a64/lithium-codegen-a64.cc (right):

https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
src/a64/lithium-codegen-a64.cc:3578: __ cbz(w2, deferred->entry());
On 2014/01/23 15:02:14, Rodolph Perfetta wrote:
> cbz -> Cbz

Done.

https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
src/a64/lithium-codegen-a64.cc:3583: __ And(w4, w2, Operand(0xFFFF));
On 2014/01/23 15:02:14, Rodolph Perfetta wrote:
> No need for Operand, And(w4, 0xFFFF) works.
> 
> This applies to mov and and below too.

Done.

https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
src/a64/lithium-codegen-a64.cc:3602: __ bind(deferred->exit());
On 2014/01/23 15:02:14, Rodolph Perfetta wrote:
> bind -> Bind

Done.

https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
src/a64/lithium-codegen-a64.cc:3610: __
CallCFunction(ExternalReference::random_uint32_function(isolate()), 0);
On 2014/01/23 15:02:14, Rodolph Perfetta wrote:
> the function takes a parameter.

Done.

[Rodolph Perfetta, 2014-01-24 15:13:38]

On 2014/01/24 06:37:52, Benedikt Meurer wrote:
>
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64.cc
> File src/a64/lithium-codegen-a64.cc (right):
> 
>
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
> src/a64/lithium-codegen-a64.cc:3578: __ cbz(w2, deferred->entry());
> On 2014/01/23 15:02:14, Rodolph Perfetta wrote:
> > cbz -> Cbz
> 
> Done.
> 
>
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
> src/a64/lithium-codegen-a64.cc:3583: __ And(w4, w2, Operand(0xFFFF));
> On 2014/01/23 15:02:14, Rodolph Perfetta wrote:
> > No need for Operand, And(w4, 0xFFFF) works.
> > 
> > This applies to mov and and below too.
> 
> Done.
> 
>
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
> src/a64/lithium-codegen-a64.cc:3602: __ bind(deferred->exit());
> On 2014/01/23 15:02:14, Rodolph Perfetta wrote:
> > bind -> Bind
> 
> Done.
> 
>
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
> src/a64/lithium-codegen-a64.cc:3610: __
> CallCFunction(ExternalReference::random_uint32_function(isolate()), 0);
> On 2014/01/23 15:02:14, Rodolph Perfetta wrote:
> > the function takes a parameter.
> 
> Done.

The diff is empty, can you re upload.

[Benedikt Meurer, 2014-01-27 06:40:00]

On 2014/01/24 15:13:38, Rodolph Perfetta wrote:
> On 2014/01/24 06:37:52, Benedikt Meurer wrote:
> >
>
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64.cc
> > File src/a64/lithium-codegen-a64.cc (right):
> > 
> >
>
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
> > src/a64/lithium-codegen-a64.cc:3578: __ cbz(w2, deferred->entry());
> > On 2014/01/23 15:02:14, Rodolph Perfetta wrote:
> > > cbz -> Cbz
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
> > src/a64/lithium-codegen-a64.cc:3583: __ And(w4, w2, Operand(0xFFFF));
> > On 2014/01/23 15:02:14, Rodolph Perfetta wrote:
> > > No need for Operand, And(w4, 0xFFFF) works.
> > > 
> > > This applies to mov and and below too.
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
> > src/a64/lithium-codegen-a64.cc:3602: __ bind(deferred->exit());
> > On 2014/01/23 15:02:14, Rodolph Perfetta wrote:
> > > bind -> Bind
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/145693002/diff/1/src/a64/lithium-codegen-a64....
> > src/a64/lithium-codegen-a64.cc:3610: __
> > CallCFunction(ExternalReference::random_uint32_function(isolate()), 0);
> > On 2014/01/23 15:02:14, Rodolph Perfetta wrote:
> > > the function takes a parameter.
> > 
> > Done.
> 
> The diff is empty, can you re upload.

Should be fine now, although the incremental diff seems to be broken (Rietvield
*arg*).

[Rodolph Perfetta, 2014-01-27 09:48:42]

lgtm.

[Benedikt Meurer, 2014-01-27 12:55:23]

Committed patchset #2 manually as r18852 (presubmit successful).