Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1456923003: [api] Remove deprecated and unused Set/Map::FromArray (Closed)

Created:
5 years, 1 month ago by adamk
Modified:
5 years, 1 month ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Remove deprecated and unused Set/Map::FromArray R=jochen@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng Committed: https://crrev.com/ed7d7954832d14ddc5a5afc037d84f6f584d6d33 Cr-Commit-Position: refs/heads/master@{#32099}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -72 lines) Patch
M include/v8.h View 2 chunks +0 lines, -17 lines 0 comments Download
M src/api.cc View 2 chunks +0 lines, -31 lines 0 comments Download
M src/contexts.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/js/collection.js View 2 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
adamk
5 years, 1 month ago (2015-11-18 19:40:16 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-11-18 20:36:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456923003/1
5 years, 1 month ago (2015-11-18 20:50:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456923003/1
5 years, 1 month ago (2015-11-18 20:50:59 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/142683)
5 years, 1 month ago (2015-11-18 22:24:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456923003/1
5 years, 1 month ago (2015-11-18 22:49:46 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 02:19:56 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 02:20:31 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ed7d7954832d14ddc5a5afc037d84f6f584d6d33
Cr-Commit-Position: refs/heads/master@{#32099}

Powered by Google App Engine
This is Rietveld 408576698