Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1456913002: Use thread with looper and native message loop for vsync service. (Closed)

Created:
5 years, 1 month ago by qsr
Modified:
5 years, 1 month ago
Reviewers:
abarth, ppi
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Use thread with looper and native message loop for vsync service. This allows not to switch thread when communicating with the choreographer. This CL introduces NativeHandlerThread. This is a HandlerThread (associated to an android Looper) that is also associated to a native message loop to be able to receive mojo messages. R=ppi@chromium.org BUG=https://github.com/domokit/mojo/issues/535 Committed: https://chromium.googlesource.com/external/mojo/+/e15069cf509e8e2fe78200379d616b17eef81ece

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -46 lines) Patch
M services/vsync/src/org/chromium/mojo/vsync/VSyncProviderImpl.java View 2 chunks +6 lines, -35 lines 0 comments Download
M shell/BUILD.gn View 3 chunks +4 lines, -0 lines 0 comments Download
M shell/android/android_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M shell/android/apk/src/org/chromium/mojo/shell/JavaApplicationRegistry.java View 1 chunk +1 line, -1 line 0 comments Download
A shell/android/apk/src/org/chromium/mojo/shell/NativeHandlerThread.java View 1 chunk +54 lines, -0 lines 0 comments Download
M shell/android/apk/src/org/chromium/mojo/shell/VsyncFactory.java View 2 chunks +11 lines, -6 lines 0 comments Download
M shell/android/library_loader.cc View 2 chunks +3 lines, -1 line 0 comments Download
A shell/android/native_handler_thread.h View 1 chunk +16 lines, -0 lines 0 comments Download
A shell/android/native_handler_thread.cc View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
qsr
5 years, 1 month ago (2015-11-18 10:02:22 UTC) #1
ppi
lgtm
5 years, 1 month ago (2015-11-18 12:09:09 UTC) #2
qsr
Committed patchset #1 (id:1) manually as e15069cf509e8e2fe78200379d616b17eef81ece (presubmit successful).
5 years, 1 month ago (2015-11-18 12:59:32 UTC) #3
abarth
5 years, 1 month ago (2015-11-18 16:18:35 UTC) #5
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698