Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1456903002: Revert of Multibuffer reader implementation (Closed)

Created:
5 years, 1 month ago by msramek
Modified:
5 years, 1 month ago
Reviewers:
hubbe, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@media_cache
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Multibuffer reader implementation (patchset #5 id:80001 of https://codereview.chromium.org/1420883004/ ) Reason for revert: This CL probably broke media_blink_unittests: MultiBufferTest.RandomTest and MultiBufferTest.RandomTest_RangeSupported. Original issue's description: > Multibuffer reader implementation > > Provides a simpler, byte-oriented api for getting data out of a multibuffer. > This CL also has the unit tests for the multibuffer itself. (Since those tests > uses the MultiBufferReader class.) > > Depends on: > https://codereview.chromium.org/1165903002 > > Media cache design doc: > https://docs.google.com/document/d/15q6LTG0iDUe30QcoMtj4XNmKCa_7W_Q2uUIPFsJhS1E/edit > > BUG=514719 > > Committed: https://crrev.com/f8b2532f9f9b4a35f396602bb80dfc34ee102fe4 > Cr-Commit-Position: refs/heads/master@{#360244} TBR=dalecurtis@chromium.org,hubbe@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=514719, 557589 Committed: https://crrev.com/74b218224a21219388a640ffa3dd680e947ef257 Cr-Commit-Position: refs/heads/master@{#360312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -912 lines) Patch
M media/blink/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M media/blink/interval_map.h View 3 chunks +5 lines, -3 lines 0 comments Download
M media/blink/media_blink.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
D media/blink/multibuffer_reader.h View 1 chunk +0 lines, -158 lines 0 comments Download
D media/blink/multibuffer_reader.cc View 1 chunk +0 lines, -237 lines 0 comments Download
D media/blink/multibuffer_unittest.cc View 1 chunk +0 lines, -508 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
msramek
Created Revert of Multibuffer reader implementation
5 years, 1 month ago (2015-11-18 09:27:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456903002/1
5 years, 1 month ago (2015-11-18 09:28:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 09:29:18 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 09:30:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74b218224a21219388a640ffa3dd680e947ef257
Cr-Commit-Position: refs/heads/master@{#360312}

Powered by Google App Engine
This is Rietveld 408576698