tools/lto/LTOCodeGenerator.cpp - Issue 14569012: PNaCl ABI: Promote illegal integer types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/lto/LTOCodeGenerator.cpp

Issue 14569012: PNaCl ABI: Promote illegal integer types (Closed) Base URL: http://git.chromium.org/native_client/pnacl-llvm.git@master

Patch Set: use upper-clear invariant rather than sign-extend Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/lto/LTOCodeGenerator.cpp

diff --git a/tools/lto/LTOCodeGenerator.cpp b/tools/lto/LTOCodeGenerator.cpp

index 7b89f81aa43bc5e9ba5f86177c91e26973d701b4..904327d09ee73cff6e645c8aab629c72c1346b8c 100644

--- a/tools/lto/LTOCodeGenerator.cpp

+++ b/tools/lto/LTOCodeGenerator.cpp

@@ -108,6 +108,7 @@ bool LTOCodeGenerator::addModule(LTOModule* mod, std::string& errMsg) {

/// The merging does not happen until linkGatheredModulesAndDispose().

bool LTOCodeGenerator::gatherModuleForLinking(LTOModule* mod) {

_gatheredModules.push_back(mod);

+ return false;

Mark Seaborn 2013/05/06 17:04:06 How is this change related to the new pass? Commi

Derek Schuff 2013/05/08 22:33:28 oops, yes this just fixes a warning, split into a

}

/// Merge all modules gathered from gatherModuleForLinking(), and