Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: test/NaCl/PNaClABI/types-function.ll

Issue 14569012: PNaCl ABI: Promote illegal integer types (Closed) Base URL: http://git.chromium.org/native_client/pnacl-llvm.git@master
Patch Set: use upper-clear invariant rather than sign-extend Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/NaCl/PNaClABI/types-function.ll
diff --git a/test/NaCl/PNaClABI/types-function.ll b/test/NaCl/PNaClABI/types-function.ll
index d1ead912cbd0275392a6c465fc6df90a7360ce71..32004d39ad9674a09e0368c6c65785f39fb27e4d 100644
--- a/test/NaCl/PNaClABI/types-function.ll
+++ b/test/NaCl/PNaClABI/types-function.ll
@@ -17,12 +17,10 @@ define void @types() {
; see below...
%h3 = fadd double 0.0, fpext (half 0.0 to double)
-; TODO(mseaborn): Re-enable integer size checking.
-; See https://code.google.com/p/nativeclient/issues/detail?id=3360
-; C;HECK: Function types has instruction operand with disallowed type: i17*
-; store i32 0, i32* bitcast (i17* @a2 to i32*), align 4
-; C;HECK: Function types has instruction operand with disallowed type: i15
-; call void @func(i15 1)
+; CHECK: Function types has instruction operand with disallowed type: i17*
Mark Seaborn 2013/05/06 17:04:06 Also not committable yet...
+ store i32 0, i32* bitcast (i17* @a2 to i32*), align 4
+; CHECK: Function types has instruction operand with disallowed type: i15
+ call void @func(i15 1)
; CHECK: Function types has disallowed instruction metadata: !foo
ret void, !foo !0

Powered by Google App Engine
This is Rietveld 408576698