Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: test/NaCl/PNaClABI/types.ll

Issue 14569012: PNaCl ABI: Promote illegal integer types (Closed) Base URL: http://git.chromium.org/native_client/pnacl-llvm.git@master
Patch Set: move logic to convertInstruction Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/NaCl/PNaClABI/types.ll
diff --git a/test/NaCl/PNaClABI/types.ll b/test/NaCl/PNaClABI/types.ll
index f7685a9d616a4737c93c1b71ac2ccb066720d363..e42a7f3dd92b7d5ef3e62f2fa804a7d5d6516dd0 100644
--- a/test/NaCl/PNaClABI/types.ll
+++ b/test/NaCl/PNaClABI/types.ll
@@ -4,14 +4,14 @@
; Basic global types
-; TODO(mseaborn): Re-enable integer size checking.
+; TODO(dschuff): expand or disable generation of types >i64
; See https://code.google.com/p/nativeclient/issues/detail?id=3360
-; C;HECK: Variable i4 has disallowed type: i4
-;@i4 = private global i4 0
-; C;HECK: Variable i33 has disallowed type: i33
-;@i33 = private global i33 0
-; C;HECK: Variable i128 has disallowed type: i128
-;@i128 = private global i128 0
+; CHECK: Variable i4 has disallowed type: i4
+@i4 = private global i4 0
+; CHECK: Variable i33 has disallowed type: i33
+@i33 = private global i33 0
+; CHECK: Variable i128 has disallowed type: i128
+@i128 = private global i128 0
; CHECK: Variable hlf has disallowed type: half
@hlf = private global half 0.0
@@ -58,13 +58,12 @@
; types in arrays, structs, etc
; CHECK: Variable p2 has disallowed type: half*
@p2 = private global half* undef
-; TODO(mseaborn): Re-enable integer size checking.
-; C;HECK: Variable a2 has disallowed type: [2 x i33]
-;@a2 = private global [ 2 x i33 ] undef
+; CHECK: Variable a2 has disallowed type: [2 x i33]
+@a2 = private global [ 2 x i33 ] undef
; CHECK: Variable s2 has disallowed type: { half, i32 }
@s2 = private global { half, i32 } undef
-; C;HECK: Variable s3 has disallowed type: { float, i33 }
-;@s3 = private global { float, i33 } undef
+; CHECK: Variable s3 has disallowed type: { float, i33 }
+@s3 = private global { float, i33 } undef
; CHECK: Variable s4 has disallowed type: { i32, { i32, half }, float }
@s4 = private global { i32, { i32, half }, float } undef
; CHECK-NOT: disallowed

Powered by Google App Engine
This is Rietveld 408576698