Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/Analysis/NaCl/PNaClABITypeChecker.cpp

Issue 14569012: PNaCl ABI: Promote illegal integer types (Closed) Base URL: http://git.chromium.org/native_client/pnacl-llvm.git@master
Patch Set: move logic to convertInstruction Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/llvm/Transforms/NaCl.h ('k') | lib/Transforms/NaCl/CMakeLists.txt » ('j') | lib/Transforms/NaCl/PromoteIntegers.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/Analysis/NaCl/PNaClABITypeChecker.cpp
diff --git a/lib/Analysis/NaCl/PNaClABITypeChecker.cpp b/lib/Analysis/NaCl/PNaClABITypeChecker.cpp
index 9afa04d5b53fe1a922b22edbd7a852e2da7bc0ed..22aeeeff60bfc492a60d1266c71b590420295c46 100644
--- a/lib/Analysis/NaCl/PNaClABITypeChecker.cpp
+++ b/lib/Analysis/NaCl/PNaClABITypeChecker.cpp
@@ -53,10 +53,10 @@ bool PNaClABITypeChecker::isValidType(const Type *Ty) {
// integer sizes.
// TODO(mseaborn): Re-enable the check when it passes.
// See https://code.google.com/p/nativeclient/issues/detail?id=3360
- Valid = true;
- // Width = cast<const IntegerType>(Ty)->getBitWidth();
- // Valid = (Width == 1 || Width == 8 || Width == 16 ||
- // Width == 32 || Width == 64);
+ //Valid = true;
+ Width = cast<const IntegerType>(Ty)->getBitWidth();
+ Valid = (Width == 1 || Width == 8 || Width == 16 ||
+ Width == 32 || Width == 64);
break;
case Type::FunctionTyID:
case Type::StructTyID:
« no previous file with comments | « include/llvm/Transforms/NaCl.h ('k') | lib/Transforms/NaCl/CMakeLists.txt » ('j') | lib/Transforms/NaCl/PromoteIntegers.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698