PNaCl ABI: Promote illegal integer types

lib/Analysis/NaCl/PNaClABITypeChecker.cpp

 //===- PNaClABICheckTypes.h - Verify PNaCl ABI rules --------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // Common type-checking code for module and function-level passes
@@ skipping 35 matching lines @@
       // Derived types
     case Type::VectorTyID:
       Valid = false;
       break;
     case Type::IntegerTyID:
       // The check for integer sizes below currently does not pass on
       // all NaCl tests because some LLVM passes introduce unusual
       // integer sizes.
       // TODO(mseaborn): Re-enable the check when it passes.
       // See https://code.google.com/p/nativeclient/issues/detail?id=3360
-      Valid = true;
-      // Width = cast<const IntegerType>(Ty)->getBitWidth();
-      // Valid = (Width == 1 || Width == 8 || Width == 16 ||
-      //          Width == 32 || Width == 64);
+      //Valid = true;

[Mark Seaborn, 2013/05/06 17:04:06]

You'll need to undo this before committing since the new pass isn't enabled yet.
 (As an aside, I'd like to move the enabled-passes list into the LLVM branch
repo to make changes like this easier.)

+      Width = cast<const IntegerType>(Ty)->getBitWidth();
+      Valid = (Width == 1 || Width == 8 || Width == 16 ||
+                Width == 32 || Width == 64);
       break;
     case Type::FunctionTyID:
     case Type::StructTyID:
     case Type::ArrayTyID:
     case Type::PointerTyID:
       // These types are valid if their contained or pointed-to types are
       // valid. Since struct/pointer subtype relationships may be circular,
       // mark the current type as valid to avoid infinite recursion
       Valid = true;
       VisitedTypes[Ty] = true;
@@ skipping 57 matching lines @@
   for (unsigned i = 0, e = N->getNumOperands(); i != e; i++) {
     if (Value *Op = N->getOperand(i)) {
       if (Type *Invalid = checkTypesInConstant(dyn_cast<Constant>(Op))) {
         VisitedConstants[N] = Invalid;
         return Invalid;
       }
     }
   }
   return NULL;
 }