Issue 14569010: Enable the settings UI to toggle the device ID on Windows.

Issue 14569010: Enable the settings UI to toggle the device ID on Windows. (Closed)

Created:
7 years, 7 months ago by raymes

Modified:
7 years, 7 months ago

Reviewers:
Bernhard Bauer, raymes1, Will Drewry, Dan Beam, Mike West, not at google - send to devlin

CC:
chromium-reviews, dbeam+watch-options_chromium.org, Aaron Boodman, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, mkearney1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable the settings UI to toggle the device ID on Windows. Since the device ID is now exposed on Windows through the PPB_Flash API, we should enable the settings UI to toggle it. BUG=235193 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198082

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : . #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/content_settings.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/content_settings_handler.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/api/privacy.json	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/preference/standard/test.js	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

raymes

wad: PTAL dbeam for OWNERS: chrome\browser\resources\options\content_settings.html chrome\browser\ui\webui\options\content_settings_handler.cc mkearney for OWNERS: chrome\common\extensions\api\privacy.json

7 years, 7 months ago (2013-05-01 20:20:12 UTC) #1

Dan Beam

lgtm https://codereview.chromium.org/14569010/diff/2002/chrome/browser/ui/webui/options/content_settings_handler.cc File chrome/browser/ui/webui/options/content_settings_handler.cc (right): https://codereview.chromium.org/14569010/diff/2002/chrome/browser/ui/webui/options/content_settings_handler.cc#newcode343 chrome/browser/ui/webui/options/content_settings_handler.cc:343: #if defined(OS_WIN) || defined(OS_CHROMEOS) nit: #if defined(OS_CHROMEOS) || ...

7 years, 7 months ago (2013-05-01 20:53:22 UTC) #2

raymes

https://codereview.chromium.org/14569010/diff/2002/chrome/browser/ui/webui/options/content_settings_handler.cc File chrome/browser/ui/webui/options/content_settings_handler.cc (right): https://codereview.chromium.org/14569010/diff/2002/chrome/browser/ui/webui/options/content_settings_handler.cc#newcode343 chrome/browser/ui/webui/options/content_settings_handler.cc:343: #if defined(OS_WIN) || defined(OS_CHROMEOS) On 2013/05/01 20:53:22, Dan Beam ...

7 years, 7 months ago (2013-05-02 17:20:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/14569010/17001

7 years, 7 months ago (2013-05-02 22:51:31 UTC) #8

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=110230

7 years, 7 months ago (2013-05-03 05:05:18 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/14569010/17001

7 years, 7 months ago (2013-05-03 05:10:23 UTC) #10

Mike West

On 2013/05/03 05:10:23, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...

7 years, 7 months ago (2013-05-03 07:30:43 UTC) #11

Message was sent while issue was closed.

Change committed as 198082

Expand Messages | Collapse Messages