Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1345)

Unified Diff: third_party/WebKit/Source/web/ImageDecodeBench.cpp

Issue 1456873003: More regular Platform implementations in unit tests (reland.) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: have GN disable c4267 also Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/BUILD.gn ('k') | third_party/WebKit/Source/web/tests/TextFinderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/ImageDecodeBench.cpp
diff --git a/third_party/WebKit/Source/web/ImageDecodeBench.cpp b/third_party/WebKit/Source/web/ImageDecodeBench.cpp
index 988f2e8f87c89077dc604a2db175ade5901016f3..41c3870b2027dcb0954da056d0b22fa7019ecb8d 100644
--- a/third_party/WebKit/Source/web/ImageDecodeBench.cpp
+++ b/third_party/WebKit/Source/web/ImageDecodeBench.cpp
@@ -25,6 +25,7 @@ http://crbug.com/398235#c103 and http://crbug.com/258324#c5
#include "platform/SharedBuffer.h"
#include "platform/image-decoders/ImageDecoder.h"
+#include "platform/testing/TestingPlatformSupport.h"
#include "public/platform/Platform.h"
#include "public/web/WebKit.h"
#include "wtf/OwnPtr.h"
@@ -360,18 +361,8 @@ int main(int argc, char* argv[])
// Create a web platform without V8.
- class WebPlatform : public blink::Platform {
+ class WebPlatform : public TestingPlatformSupport {
public:
- const unsigned char* getTraceCategoryEnabledFlag(const char*) override
- {
- return reinterpret_cast<const unsigned char *>("nope-none-nada");
- }
-
- void cryptographicallyRandomValues(unsigned char*, size_t) override
- {
- RELEASE_ASSERT_NOT_REACHED();
- }
-
void screenColorProfile(WebVector<char>* profile) override
{
getScreenColorProfile(profile); // Returns a whacked color profile.
« no previous file with comments | « third_party/WebKit/Source/web/BUILD.gn ('k') | third_party/WebKit/Source/web/tests/TextFinderTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698