Finch experiment: auto-detect text encoding

chrome/browser/ui/prefs/prefs_tab_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/prefs/prefs_tab_helper.h"
 
 #include <set>
 #include <string>
 
+#include "base/command_line.h"
 #include "base/memory/singleton.h"
+#include "base/metrics/field_trial.h"
 #include "base/prefs/overlay_user_pref_store.h"
 #include "base/prefs/pref_change_registrar.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/profiles/incognito_helpers.h"
@@ skipping 290 matching lines @@
 void RegisterLocalizedFontPref(user_prefs::PrefRegistrySyncable* registry,
                                const char* path,
                                int default_message_id) {
   int val = 0;
   bool success = base::StringToInt(l10n_util::GetStringUTF8(
       default_message_id), &val);
   DCHECK(success);
   registry->RegisterIntegerPref(path, val);
 }
 
+bool IsAutodetectEncodingEnabled() {

[battre, 2015/12/02 13:08:26]

nit: Should this be IsAutodetectEncodingEnabledByDefault()?

[Jinsuk Kim, 2015/12/02 23:14:38]

Done.

+  const std::string group_name = base::FieldTrialList::FindFullName(
+      "AutodetectEncoding");
+  return base::StartsWith(group_name,
+                          "Enabled",
+                          base::CompareCase::INSENSITIVE_ASCII);
+}
+
 }  // namespace
 
 // Watching all these settings per tab is slow when a user has a lot of tabs and
 // and they use session restore. So watch them once per profile.
 // http://crbug.com/452693
 class PrefWatcher : public KeyedService {
  public:
   explicit PrefWatcher(Profile* profile) : profile_(profile) {
     pref_change_registrar_.Init(profile_->GetPrefs());
 
@@ skipping 243 matching lines @@
 #endif
 
   RegisterLocalizedFontPref(registry, prefs::kWebKitDefaultFontSize,
                             IDS_DEFAULT_FONT_SIZE);
   RegisterLocalizedFontPref(registry, prefs::kWebKitDefaultFixedFontSize,
                             IDS_DEFAULT_FIXED_FONT_SIZE);
   RegisterLocalizedFontPref(registry, prefs::kWebKitMinimumFontSize,
                             IDS_MINIMUM_FONT_SIZE);
   RegisterLocalizedFontPref(registry, prefs::kWebKitMinimumLogicalFontSize,
                             IDS_MINIMUM_LOGICAL_FONT_SIZE);
+  bool uses_universal_detector = IsAutodetectEncodingEnabled() ?
+      true : l10n_util::GetStringUTF8(IDS_USES_UNIVERSAL_DETECTOR) == "true";

[battre, 2015/12/02 13:08:26]

... = IsAutodetectEncodingEnabled() ||
l10n_util::GetStringUTF8(IDS_USES_UNIVERSAL_DETECTOR) == "true";

[Jinsuk Kim, 2015/12/02 23:14:38]

Done.

   registry->RegisterBooleanPref(
       prefs::kWebKitUsesUniversalDetector,
-      l10n_util::GetStringUTF8(IDS_USES_UNIVERSAL_DETECTOR) == "true",
+      uses_universal_detector,
       user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
   registry->RegisterStringPref(
       prefs::kStaticEncodings,
       l10n_util::GetStringUTF8(IDS_STATIC_ENCODING_LIST));
   registry->RegisterStringPref(prefs::kRecentlySelectedEncoding, std::string());
 }
 
 // static
 void PrefsTabHelper::GetServiceInstance() {
   PrefWatcherFactory::GetInstance();
@@ skipping 61 matching lines @@
   }
 }
 
 void PrefsTabHelper::OnWebPrefChanged(const std::string& pref_name) {
 #if !defined(OS_ANDROID)
   OnFontFamilyPrefChanged(pref_name);
 #endif
 
   web_contents_->GetRenderViewHost()->OnWebkitPreferencesChanged();
 }