Add small paths GM

Add small paths GM

Used to testing caching and quality of distance field paths.

Committed: https://skia.googlesource.com/skia/+/8450cc3d3d5c6df6caad0445557871f48108d041

[jvanverth1, 2015-11-18 20:58:50]

jvanverth@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2015-11-18 21:06:51]

lgtm

https://codereview.chromium.org/1456823003/diff/1/gm/smallpaths.cpp
File gm/smallpaths.cpp (right):

https://codereview.chromium.org/1456823003/diff/1/gm/smallpaths.cpp#newcode1
gm/smallpaths.cpp:1: /*
date ?

https://codereview.chromium.org/1456823003/diff/1/gm/smallpaths.cpp#newcode109
gm/smallpaths.cpp:109: static SkScalar xOffset = 5.f;
kill this ?

https://codereview.chromium.org/1456823003/diff/1/gm/smallpaths.cpp#newcode134
gm/smallpaths.cpp:134: 
make_charging_icon ?

https://codereview.chromium.org/1456823003/diff/1/gm/smallpaths.cpp#newcode198
gm/smallpaths.cpp:198: 
// This GM tests out drawing small paths (i.e., for Ganesh, using the Distance
Field path renderer) which are filled, stroked and filledAndStroked. In
particular this ensures that any cache keys in use include the stroking
parameters.

?

Should we include another column with a different stroke width ?

https://codereview.chromium.org/1456823003/diff/1/gm/smallpaths.cpp#newcode220
gm/smallpaths.cpp:220: 
// First column is just filled

?

https://codereview.chromium.org/1456823003/diff/1/gm/smallpaths.cpp#newcode229
gm/smallpaths.cpp:229: 
// Second column is stroked

?

https://codereview.chromium.org/1456823003/diff/1/gm/smallpaths.cpp#newcode260
gm/smallpaths.cpp:260: 
DEF_GM ?

[jvanverth1, 2015-11-18 21:15:52]

https://codereview.chromium.org/1456823003/diff/1/gm/smallpaths.cpp
File gm/smallpaths.cpp (right):

https://codereview.chromium.org/1456823003/diff/1/gm/smallpaths.cpp#newcode1
gm/smallpaths.cpp:1: /*
On 2015/11/18 21:06:51, robertphillips wrote:
> date ?

Done.

https://codereview.chromium.org/1456823003/diff/1/gm/smallpaths.cpp#newcode109
gm/smallpaths.cpp:109: static SkScalar xOffset = 5.f;
On 2015/11/18 21:06:51, robertphillips wrote:
> kill this ?

Done.

https://codereview.chromium.org/1456823003/diff/1/gm/smallpaths.cpp#newcode134
gm/smallpaths.cpp:134: 
On 2015/11/18 21:06:51, robertphillips wrote:
> make_charging_icon ?

Done.

https://codereview.chromium.org/1456823003/diff/1/gm/smallpaths.cpp#newcode198
gm/smallpaths.cpp:198: 
On 2015/11/18 21:06:51, robertphillips wrote:
> // This GM tests out drawing small paths (i.e., for Ganesh, using the Distance
> Field path renderer) which are filled, stroked and filledAndStroked. In
> particular this ensures that any cache keys in use include the stroking
> parameters.
> 
> ?
> 
> Should we include another column with a different stroke width ?

Done.

https://codereview.chromium.org/1456823003/diff/1/gm/smallpaths.cpp#newcode220
gm/smallpaths.cpp:220: 
On 2015/11/18 21:06:51, robertphillips wrote:
> // First column is just filled
> 
> ?

Done.

https://codereview.chromium.org/1456823003/diff/1/gm/smallpaths.cpp#newcode229
gm/smallpaths.cpp:229: 
On 2015/11/18 21:06:51, robertphillips wrote:
> // Second column is stroked
> 
> ?

Done.

https://codereview.chromium.org/1456823003/diff/1/gm/smallpaths.cpp#newcode260
gm/smallpaths.cpp:260: 
On 2015/11/18 21:06:51, robertphillips wrote:
> DEF_GM ?

Done.

[jvanverth1, 2015-11-18 21:16:03]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2015-11-18 21:16:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1456823003/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2015-11-18 21:16:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456823003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456823003/20001

[commit-bot: I haz the power, 2015-11-18 21:19:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-18 21:19:46]

Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[jvanverth1, 2015-11-18 21:22:23]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2015-11-18 21:22:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1456823003/#ps40001
(title: "Fix for Windows")

[commit-bot: I haz the power, 2015-11-18 21:22:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456823003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456823003/40001

[commit-bot: I haz the power, 2015-11-18 21:40:20]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/8450cc3d3d5c6df6caad0445557871f48108d041