third_party/WebKit/Source/core/paint/BoxPainter.cpp - Issue 1456813002: Calculate Background Image Geometries using sub-pixel values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/BoxPainter.cpp

Issue 1456813002: Calculate Background Image Geometries using sub-pixel values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unit fix and moar ref test corrections. Still no expected results. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp ('K') | « third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp ('k') | third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/BoxPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/BoxPainter.cpp b/third_party/WebKit/Source/core/paint/BoxPainter.cpp

index c56ba6aef747f79079e4d69b08dc94241e8f2e73..542996c0f540df88e76bd6fbb7db064cbd20be67 100644

--- a/third_party/WebKit/Source/core/paint/BoxPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/BoxPainter.cpp

@@ -464,15 +464,15 @@ void BoxPainter::paintFillLayerExtended(const LayoutBoxModelObject& obj, const P

// if op != SkXfermode::kSrcOver_Mode, a mask is being painted.

SkXfermode::Mode compositeOp = op == SkXfermode::kSrcOver_Mode ? bgOp : op;

const LayoutObject* clientForBackgroundImage = backgroundObject ? backgroundObject : &obj;

- RefPtr<Image> image = bgImage->image(clientForBackgroundImage, geometry.imageContainerSize(), obj.style()->effectiveZoom());

+ RefPtr<Image> image = bgImage->image(clientForBackgroundImage, flooredIntSize(geometry.imageContainerSize()), obj.style()->effectiveZoom());

InterpolationQuality interpolationQuality = chooseInterpolationQuality(*clientForBackgroundImage, context, image.get(), &bgLayer, LayoutSize(geometry.tileSize()));

if (bgLayer.maskSourceType() == MaskLuminance)

context->setColorFilter(ColorFilterLuminanceToAlpha);

InterpolationQuality previousInterpolationQuality = context->imageInterpolationQuality();

context->setImageInterpolationQuality(interpolationQuality);

TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "PaintImage", "data", InspectorPaintImageEvent::data(obj, *bgImage));

- context->drawTiledImage(image.get(), geometry.destRect(), geometry.phase(), geometry.tileSize(),

- compositeOp, geometry.spaceSize());

+ context->drawTiledImage(image.get(), FloatRect(geometry.destRect()), FloatPoint(geometry.phase()), FloatSize(geometry.tileSize()),

+ compositeOp, FloatSize(geometry.spaceSize()));

context->setImageInterpolationQuality(previousInterpolationQuality);

}