tools/telemetry/telemetry/internal/platform/power_monitor/android_power_monitor_base.py - Issue 1456803002: move set charging to powermonitorcontroller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/platform/power_monitor/android_power_monitor_base.py

Issue 1456803002: move set charging to powermonitorcontroller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move setcharging to powermonitorcontroller Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/platform/power_monitor/android_fuelgauge_power_monitor_unittest.py ('k') | tools/telemetry/telemetry/internal/platform/power_monitor/android_power_monitor_controller.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/platform/power_monitor/android_power_monitor_base.py

diff --git a/tools/telemetry/telemetry/internal/platform/power_monitor/android_power_monitor_base.py b/tools/telemetry/telemetry/internal/platform/power_monitor/android_power_monitor_base.py

index d14089294328b56fc598940ff0d469e9166f54ad..afcc87d9b3050c13590c6443ac5d17ada5c14f63 100644

--- a/tools/telemetry/telemetry/internal/platform/power_monitor/android_power_monitor_base.py

+++ b/tools/telemetry/telemetry/internal/platform/power_monitor/android_power_monitor_base.py

@@ -34,12 +34,3 @@ class AndroidPowerMonitorBase(power_monitor.PowerMonitor):

if power_data['application_energy_consumption_mwh'] == 0:

logging.warning('Power data is returning 0 usage for %s. %s'

% (package, power_data))

- def _ChargingOff(self, battery):

- battery.SetCharging(False)

- def _ChargingOn(self, battery):

- if battery.GetCharging():

- logging.warning('Charging re-enabled during test.'

- 'Results may be inaccurate.')

- battery.SetCharging(True)