tools/telemetry/telemetry/internal/platform/power_monitor/android_fuelgauge_power_monitor.py - Issue 1456803002: move set charging to powermonitorcontroller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/platform/power_monitor/android_fuelgauge_power_monitor.py

Issue 1456803002: move set charging to powermonitorcontroller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move setcharging to powermonitorcontroller Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/platform/power_monitor/android_dumpsys_power_monitor_unittest.py ('k') | tools/telemetry/telemetry/internal/platform/power_monitor/android_fuelgauge_power_monitor_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/platform/power_monitor/android_fuelgauge_power_monitor.py

diff --git a/tools/telemetry/telemetry/internal/platform/power_monitor/android_fuelgauge_power_monitor.py b/tools/telemetry/telemetry/internal/platform/power_monitor/android_fuelgauge_power_monitor.py

index 0e7fe306276c0f15ee103ec881bbc4f235f682c4..c3bb56905c71c6627ebbd261a1d99e8aef6196ee 100644

--- a/tools/telemetry/telemetry/internal/platform/power_monitor/android_fuelgauge_power_monitor.py

+++ b/tools/telemetry/telemetry/internal/platform/power_monitor/android_fuelgauge_power_monitor.py

@@ -25,7 +25,6 @@ class FuelGaugePowerMonitor(android_power_monitor_base.AndroidPowerMonitorBase):

def StartMonitoringPower(self, browser):

self._CheckStart()

- self._ChargingOff(self._battery)

self._starting_fuel_gauge = self._battery.GetFuelGaugeChargeCounter()

def StopMonitoringPower(self):

@@ -34,7 +33,6 @@ class FuelGaugePowerMonitor(android_power_monitor_base.AndroidPowerMonitorBase):

fuel_gauge_delta = (

float((self._starting_fuel_gauge) -

self._battery.GetFuelGaugeChargeCounter()) / 1000000)

- self._ChargingOn(self._battery)

voltage = self._ParseVoltage(self._battery.GetBatteryInfo().get('voltage'))

return self.ProcessPowerData(voltage, fuel_gauge_delta)