tools/telemetry/telemetry/internal/platform/power_monitor/android_dumpsys_power_monitor.py - Issue 1456803002: move set charging to powermonitorcontroller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/platform/power_monitor/android_dumpsys_power_monitor.py

Issue 1456803002: move set charging to powermonitorcontroller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move setcharging to powermonitorcontroller Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/platform/android_platform_backend.py ('k') | tools/telemetry/telemetry/internal/platform/power_monitor/android_dumpsys_power_monitor_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/platform/power_monitor/android_dumpsys_power_monitor.py

diff --git a/tools/telemetry/telemetry/internal/platform/power_monitor/android_dumpsys_power_monitor.py b/tools/telemetry/telemetry/internal/platform/power_monitor/android_dumpsys_power_monitor.py

index eefdae885a607fb875a7c7865f031f597afe7588..e7980f449f7f79b7c9d80fdb3cf905c7efff9ac9 100644

--- a/tools/telemetry/telemetry/internal/platform/power_monitor/android_dumpsys_power_monitor.py

+++ b/tools/telemetry/telemetry/internal/platform/power_monitor/android_dumpsys_power_monitor.py

@@ -39,12 +39,10 @@ class DumpsysPowerMonitor(android_power_monitor_base.AndroidPowerMonitorBase):

# Disable the charging of the device over USB. This is necessary because the

# device only collects information about power usage when the device is not

# charging.

- self._ChargingOff(self._battery)

def StopMonitoringPower(self):

self._CheckStop()

assert self._browser

- self._ChargingOn(self._battery)

package = self._browser._browser_backend.package

self._browser = None